707577 - Create a |fast-package| target on mobile

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

This target will be used (maybe temporarily) to trigger speed optimizations when packaging.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 578946 [details] [diff] [review]
Patch

Review of attachment 578946 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we should have a separate target.  Either we're convinced enough of a change to do it for regular packaging or we shouldn't be imposing it on developers.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 578946 [details] [diff] [review]
Patch

Ok, after looking at the optimizations you have in mind I changed my mind.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5667275e8112

Should the same change be made to mobile/android/build.mk ?

Comment 4

[(not currently active) Ted Mielczarek]

Yeah, that seems more useful nowadays...

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5667275e8112

Comment 6

[Mounir Lamouri (:mounir)]

(In reply to Nick Thomas [:nthomas] from comment #3)
> Should the same change be made to mobile/android/build.mk ?

Indeed.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Over to you to do that.

Comment 8

[(not currently active) Ted Mielczarek]

Attachment: add fast-package target for mobile/android

Adds the same target for the native android app. Also fiddles the previously added target to pass the variable as a makefile var, not an environment var.

Comment 9

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/baa69540739a

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/baa69540739a