Last Comment Bug 707577 - Create a |fast-package| target on mobile
: Create a |fast-package| target on mobile
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on: 835150
Blocks: 707569
  Show dependency treegraph
 
Reported: 2011-12-04 15:30 PST by Mounir Lamouri (:mounir)
Modified: 2013-01-27 10:00 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (592 bytes, patch)
2011-12-04 15:30 PST, Mounir Lamouri (:mounir)
khuey: review+
Details | Diff | Splinter Review
add fast-package target for mobile/android (1.50 KB, patch)
2012-05-02 04:33 PDT, Ted Mielczarek [:ted.mielczarek]
khuey: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-12-04 15:30:05 PST
Created attachment 578946 [details] [diff] [review]
Patch

This target will be used (maybe temporarily) to trigger speed optimizations when packaging.
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-12-07 12:38:07 PST
Comment on attachment 578946 [details] [diff] [review]
Patch

Review of attachment 578946 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we should have a separate target.  Either we're convinced enough of a change to do it for regular packaging or we shouldn't be imposing it on developers.
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-12-07 12:44:33 PST
Comment on attachment 578946 [details] [diff] [review]
Patch

Ok, after looking at the optimizations you have in mind I changed my mind.
Comment 3 Nick Thomas [:nthomas] 2012-04-30 00:06:55 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/5667275e8112

Should the same change be made to mobile/android/build.mk ?
Comment 4 Ted Mielczarek [:ted.mielczarek] 2012-04-30 05:59:40 PDT
Yeah, that seems more useful nowadays...
Comment 6 Mounir Lamouri (:mounir) 2012-05-01 14:42:37 PDT
(In reply to Nick Thomas [:nthomas] from comment #3)
> Should the same change be made to mobile/android/build.mk ?

Indeed.
Comment 7 Nick Thomas [:nthomas] 2012-05-01 16:07:58 PDT
Over to you to do that.
Comment 8 Ted Mielczarek [:ted.mielczarek] 2012-05-02 04:33:40 PDT
Created attachment 620254 [details] [diff] [review]
add fast-package target for mobile/android

Adds the same target for the native android app. Also fiddles the previously added target to pass the variable as a makefile var, not an environment var.
Comment 9 Ted Mielczarek [:ted.mielczarek] 2012-05-03 12:14:17 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/baa69540739a
Comment 10 Ed Morley [:emorley] 2012-05-04 04:03:08 PDT
https://hg.mozilla.org/mozilla-central/rev/baa69540739a

Note You need to log in before you can comment on or make changes to this bug.