Create a |fast-package| target on mobile

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 578946 [details] [diff] [review]
Patch

This target will be used (maybe temporarily) to trigger speed optimizations when packaging.
Attachment #578946 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Blocks: 707569
Comment on attachment 578946 [details] [diff] [review]
Patch

Review of attachment 578946 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we should have a separate target.  Either we're convinced enough of a change to do it for regular packaging or we shouldn't be imposing it on developers.
Attachment #578946 - Flags: review?(khuey) → review-
Comment on attachment 578946 [details] [diff] [review]
Patch

Ok, after looking at the optimizations you have in mind I changed my mind.
Attachment #578946 - Flags: review- → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/5667275e8112

Should the same change be made to mobile/android/build.mk ?
Yeah, that seems more useful nowadays...
https://hg.mozilla.org/mozilla-central/rev/5667275e8112
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

5 years ago
(In reply to Nick Thomas [:nthomas] from comment #3)
> Should the same change be made to mobile/android/build.mk ?

Indeed.
Over to you to do that.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 620254 [details] [diff] [review]
add fast-package target for mobile/android

Adds the same target for the native android app. Also fiddles the previously added target to pass the variable as a makefile var, not an environment var.
Attachment #620254 - Flags: review?(khuey)
Attachment #620254 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/baa69540739a
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/baa69540739a
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 835150
You need to log in before you can comment on or make changes to this bug.