Last Comment Bug 707580 - Do not remove some directories generated by |make package| when re-called
: Do not remove some directories generated by |make package| when re-called
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks: 707569
  Show dependency treegraph
 
Reported: 2011-12-04 15:43 PST by Mounir Lamouri (:mounir)
Modified: 2012-04-30 08:11 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.11 KB, patch)
2011-12-04 15:43 PST, Mounir Lamouri (:mounir)
khuey: review+
Details | Diff | Review

Description Mounir Lamouri (:mounir) 2011-12-04 15:43:05 PST
Created attachment 578949 [details] [diff] [review]
Patch v1

For the moment, this happen if |make fast-package| is called.
This is enabling bug 707577 and bug 707578 optimizations.
Comment 1 Mounir Lamouri (:mounir) 2011-12-04 15:43:40 PST
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> This is enabling bug 707577 and bug 707578 optimizations.

I meant bug 707578 and bug 707579.
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-12-07 12:45:13 PST
Comment on attachment 578949 [details] [diff] [review]
Patch v1

Review of attachment 578949 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +680,5 @@
>  # do not strip the binaries actually in the tree.
>  	@echo "Creating package directory..."
> +	if ! test -d $(DIST)/$(MOZ_PKG_DIR) ; then \
> +		mkdir $(DIST)/$(MOZ_PKG_DIR); \
> +	fi

What's the point of this?

@@ +690,2 @@
>  	$(RM) -rf $(DIST)/xpt $(DIST)/manifests
> +endif

If we don't remove these directories then what ensures that XPTs and manifests that were removed are in fact, removed?  Maybe we need MOZ_FAST_PACKAGE after all :-/
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2012-04-30 08:11:02 PDT
https://hg.mozilla.org/mozilla-central/rev/5bb2bdcf67f2

Note You need to log in before you can comment on or make changes to this bug.