Do not remove some directories generated by |make package| when re-called

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 578949 [details] [diff] [review]
Patch v1

For the moment, this happen if |make fast-package| is called.
This is enabling bug 707577 and bug 707578 optimizations.
Attachment #578949 - Flags: review?(khuey)
(Assignee)

Comment 1

6 years ago
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> This is enabling bug 707577 and bug 707578 optimizations.

I meant bug 707578 and bug 707579.
Comment on attachment 578949 [details] [diff] [review]
Patch v1

Review of attachment 578949 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +680,5 @@
>  # do not strip the binaries actually in the tree.
>  	@echo "Creating package directory..."
> +	if ! test -d $(DIST)/$(MOZ_PKG_DIR) ; then \
> +		mkdir $(DIST)/$(MOZ_PKG_DIR); \
> +	fi

What's the point of this?

@@ +690,2 @@
>  	$(RM) -rf $(DIST)/xpt $(DIST)/manifests
> +endif

If we don't remove these directories then what ensures that XPTs and manifests that were removed are in fact, removed?  Maybe we need MOZ_FAST_PACKAGE after all :-/
Attachment #578949 - Flags: review?(khuey) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/5bb2bdcf67f2
https://hg.mozilla.org/mozilla-central/rev/5bb2bdcf67f2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.