707580 - Do not remove some directories generated by |make package| when re-called

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

For the moment, this happen if |make fast-package| is called.
This is enabling bug 707577 and bug 707578 optimizations.

Comment 1

[Mounir Lamouri (:mounir)]

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> This is enabling bug 707577 and bug 707578 optimizations.

I meant bug 707578 and bug 707579.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 578949 [details] [diff] [review]
Patch v1

Review of attachment 578949 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +680,5 @@
>  # do not strip the binaries actually in the tree.
>  	@echo "Creating package directory..."
> +	if ! test -d $(DIST)/$(MOZ_PKG_DIR) ; then \
> +		mkdir $(DIST)/$(MOZ_PKG_DIR); \
> +	fi

What's the point of this?

@@ +690,2 @@
>  	$(RM) -rf $(DIST)/xpt $(DIST)/manifests
> +endif

If we don't remove these directories then what ensures that XPTs and manifests that were removed are in fact, removed?  Maybe we need MOZ_FAST_PACKAGE after all :-/

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5bb2bdcf67f2

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5bb2bdcf67f2