Closed Bug 707580 Opened 10 years ago Closed 9 years ago

Do not remove some directories generated by |make package| when re-called

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
For the moment, this happen if |make fast-package| is called.
This is enabling bug 707577 and bug 707578 optimizations.
Attachment #578949 - Flags: review?(khuey)
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> This is enabling bug 707577 and bug 707578 optimizations.

I meant bug 707578 and bug 707579.
Comment on attachment 578949 [details] [diff] [review]
Patch v1

Review of attachment 578949 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +680,5 @@
>  # do not strip the binaries actually in the tree.
>  	@echo "Creating package directory..."
> +	if ! test -d $(DIST)/$(MOZ_PKG_DIR) ; then \
> +		mkdir $(DIST)/$(MOZ_PKG_DIR); \
> +	fi

What's the point of this?

@@ +690,2 @@
>  	$(RM) -rf $(DIST)/xpt $(DIST)/manifests
> +endif

If we don't remove these directories then what ensures that XPTs and manifests that were removed are in fact, removed?  Maybe we need MOZ_FAST_PACKAGE after all :-/
Attachment #578949 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/5bb2bdcf67f2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.