Account lockout notifications are not notifying the maintainer

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
User Accounts
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: reed, Assigned: glob)

Tracking

4.0.2
Bugzilla 3.6
Bug Flags:
approval +
approval4.2 +
blocking4.2 +
approval4.0 +
blocking4.0.3 +
approval3.6 +
blocking3.6.7 +

Details

(Whiteboard: [wanted-bmo])

Attachments

(1 attachment, 1 obsolete attachment)

684 bytes, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
I haven't seen a single account lockout notification sent to bmo's maintainer address since the new upstream code was implemented. Need to figure out why it seems to be broken.
(Assignee)

Comment 1

6 years ago
Created attachment 579004 [details] [diff] [review]
patch v1

this causes all the "Not an ARRAY reference at Bugzilla/Install/Util.pm" warnings in the apache log.
Assignee: user-accounts → glob
Status: NEW → ASSIGNED
Attachment #579004 - Flags: review?(LpSolit)
(Reporter)

Updated

6 years ago
Flags: blocking4.2?
Flags: blocking4.0.3?
Flags: blocking3.6.7?
Target Milestone: --- → Bugzilla 3.6
(Reporter)

Updated

6 years ago
Depends on: 355283
(Reporter)

Updated

6 years ago
Summary: Account lockout notifications are no longer notifying the maintainer → Account lockout notifications are not notifying the maintainer

Comment 2

6 years ago
Comment on attachment 579004 [details] [diff] [review]
patch v1

>=== modified file 'Bugzilla/Auth.pm'

>+            my $template = Bugzilla->template_inner(
>+                               $default_settings->{lang}->legal_values);

No, you want $default_settings->{lang}->{default_value}.
Attachment #579004 - Flags: review?(LpSolit) → review-

Comment 3

6 years ago
Let's take it for 3.6.7, as this security feature is broken.
Flags: blocking4.2?
Flags: blocking4.2+
Flags: blocking4.0.3?
Flags: blocking4.0.3+
Flags: blocking3.6.7?
Flags: blocking3.6.7+
(Assignee)

Comment 4

6 years ago
Created attachment 579067 [details] [diff] [review]
patch v2

d'oh
Attachment #579004 - Attachment is obsolete: true
Attachment #579067 - Flags: review?(LpSolit)

Comment 5

6 years ago
Comment on attachment 579067 [details] [diff] [review]
patch v2

r=LpSolit
Attachment #579067 - Flags: review?(LpSolit) → review+

Updated

6 years ago
Flags: approval4.2+
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
(Assignee)

Comment 6

6 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Auth.pm
Committed revision 8029.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/Auth.pm
Committed revision 7972.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Auth.pm
Committed revision 7663.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Auth.pm
Committed revision 7262.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified Bugzilla/Auth.pm
Committed revision 7979.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified Bugzilla/Auth.pm
Committed revision 7972.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.