Closed Bug 707594 Opened 12 years ago Closed 12 years ago

Account lockout notifications are not notifying the maintainer

Categories

(Bugzilla :: User Accounts, defect)

Product:
Bugzilla
Component:
User Accounts
Version:
4.0.2
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.6

People

(Reporter: reed, Assigned: glob)

References

Details

(Whiteboard: [wanted-bmo])

Attachments

(1 file, 1 obsolete file)

patch v2
684 bytes, patch
LpSolit
: review+
Details | Diff | Splinter Review 
I haven't seen a single account lockout notification sent to bmo's maintainer address since the new upstream code was implemented. Need to figure out why it seems to be broken.
Attached patch patch v1 (obsolete) — — Splinter Review 
this causes all the "Not an ARRAY reference at Bugzilla/Install/Util.pm" warnings in the apache log.
Assignee: user-accounts → glob
Status: NEW → ASSIGNED
Attachment #579004 - Flags: review?(LpSolit)
Flags: blocking4.2?
Flags: blocking4.0.3?
Flags: blocking3.6.7?
Target Milestone: --- → Bugzilla 3.6
Depends on: 355283
Summary: Account lockout notifications are no longer notifying the maintainer → Account lockout notifications are not notifying the maintainer
Comment on attachment 579004 [details] [diff] [review]
patch v1

>=== modified file 'Bugzilla/Auth.pm'

>+            my $template = Bugzilla->template_inner(
>+                               $default_settings->{lang}->legal_values);

No, you want $default_settings->{lang}->{default_value}.
Attachment #579004 - Flags: review?(LpSolit) → review-
Let's take it for 3.6.7, as this security feature is broken.
Flags: blocking4.2?
Flags: blocking4.2+
Flags: blocking4.0.3?
Flags: blocking4.0.3+
Flags: blocking3.6.7?
Flags: blocking3.6.7+
Attached patch patch v2 — — Splinter Review 
d'oh
Attachment #579004 - Attachment is obsolete: true
Attachment #579067 - Flags: review?(LpSolit)
Comment on attachment 579067 [details] [diff] [review]
patch v2

r=LpSolit
Attachment #579067 - Flags: review?(LpSolit) → review+
Flags: approval4.2+
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Auth.pm
Committed revision 8029.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/Auth.pm
Committed revision 7972.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Auth.pm
Committed revision 7663.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Auth.pm
Committed revision 7262.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified Bugzilla/Auth.pm
Committed revision 7979.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified Bugzilla/Auth.pm
Committed revision 7972.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.