Closed Bug 707650 Opened 8 years ago Closed 8 years ago

Remove extra slash character from web console test uris

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: rcampbell, Assigned: Tobbi)

References

Details

(Whiteboard: [good-first-bug][mentor=robcee][lang=js])

Attachments

(1 file, 1 obsolete file)

There appears to be an extra slash '/' character in our web console tests' URI references. These should be removed.

e.g., http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/test/browser/browser_webconsole_bug_578437_page_reload.js#42
Whiteboard: [good-first-bug][mentor=robcee][lang=js]
Attached patch patch (obsolete) — Splinter Review
I hope I didn't miss any occurrences of double slashes inside the tests!
Assignee: nobody → tobbi.bugs
Status: NEW → ASSIGNED
Attachment #579051 - Flags: review?(rcampbell)
wow, that was quick! In fact, it was a little *too* quick! Doing this now will break bug 692625 which'll probably require a rerun of whatever script did the work in the first place. In short, it could be messy for Ed.

Could we get this after 692625 lands?
Depends on: 692625
Comment on attachment 579051 [details] [diff] [review]
patch

Sure, I will cancel review for now, then will redo it once it was landed.
Attachment #579051 - Flags: review?(rcampbell)
Attached patch patch v2Splinter Review
patch v2
Attachment #579051 - Attachment is obsolete: true
Attachment #589168 - Flags: review?(rcampbell)
Comment on attachment 589168 [details] [diff] [review]
patch v2

make sure you flip the "patch" flag on your patch attachments!

looks good, we'll try to land this ASAP.

Thanks!
Attachment #589168 - Attachment is patch: true
Attachment #589168 - Flags: review?(rcampbell) → review+
Whiteboard: [good-first-bug][mentor=robcee][lang=js] → [good-first-bug][mentor=robcee][lang=js][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/de8da833554e

landed. Thanks for the patch!
Whiteboard: [good-first-bug][mentor=robcee][lang=js][land-in-fx-team] → [good-first-bug][mentor=robcee][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/de8da833554e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor=robcee][lang=js][fixed-in-fx-team] → [good-first-bug][mentor=robcee][lang=js]
Target Milestone: --- → Firefox 12
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.