Last Comment Bug 707650 - Remove extra slash character from web console test uris
: Remove extra slash character from web console test uris
Status: RESOLVED FIXED
[good-first-bug][mentor=robcee][lang=js]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 12
Assigned To: Tobias (:Tobbi) Markus
:
Mentors:
Depends on: 692625
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-05 05:50 PST by Rob Campbell [:rc] (:robcee)
Modified: 2012-01-19 15:49 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (45.10 KB, patch)
2011-12-05 06:19 PST, Tobias (:Tobbi) Markus
no flags Details | Diff | Splinter Review
patch v2 (22.51 KB, patch)
2012-01-17 06:06 PST, Tobias (:Tobbi) Markus
rcampbell: review+
Details | Diff | Splinter Review

Description Rob Campbell [:rc] (:robcee) 2011-12-05 05:50:14 PST
There appears to be an extra slash '/' character in our web console tests' URI references. These should be removed.

e.g., http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/test/browser/browser_webconsole_bug_578437_page_reload.js#42
Comment 1 Tobias (:Tobbi) Markus 2011-12-05 06:19:44 PST
Created attachment 579051 [details] [diff] [review]
patch

I hope I didn't miss any occurrences of double slashes inside the tests!
Comment 2 Rob Campbell [:rc] (:robcee) 2011-12-05 06:25:22 PST
wow, that was quick! In fact, it was a little *too* quick! Doing this now will break bug 692625 which'll probably require a rerun of whatever script did the work in the first place. In short, it could be messy for Ed.

Could we get this after 692625 lands?
Comment 3 Tobias (:Tobbi) Markus 2011-12-05 06:29:31 PST
Comment on attachment 579051 [details] [diff] [review]
patch

Sure, I will cancel review for now, then will redo it once it was landed.
Comment 4 Tobias (:Tobbi) Markus 2012-01-17 06:06:57 PST
Created attachment 589168 [details] [diff] [review]
patch v2

patch v2
Comment 5 Rob Campbell [:rc] (:robcee) 2012-01-19 12:17:06 PST
Comment on attachment 589168 [details] [diff] [review]
patch v2

make sure you flip the "patch" flag on your patch attachments!

looks good, we'll try to land this ASAP.

Thanks!
Comment 6 Rob Campbell [:rc] (:robcee) 2012-01-19 12:28:56 PST
https://hg.mozilla.org/integration/fx-team/rev/de8da833554e

landed. Thanks for the patch!
Comment 7 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-01-19 15:49:47 PST
https://hg.mozilla.org/mozilla-central/rev/de8da833554e

Note You need to log in before you can comment on or make changes to this bug.