embeds relation on root accessible can return not content document

RESOLVED FIXED in mozilla12

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

Trunk
mozilla12
access
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
For example, if you install Firebug extension then it adds extra document accessible that is returned by embeds relation but the tab document is expected.
(Assignee)

Comment 1

6 years ago
Created attachment 579054 [details] [diff] [review]
patch
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #579054 - Flags: review?(bolterbugz)

Updated

6 years ago
Attachment #579054 - Flags: review?(bolterbugz) → review+
https://hg.mozilla.org/mozilla-central/rev/ca7d87ab38b6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

Updated

6 years ago
Depends on: 720393

Comment 3

6 years ago
MarcoZ asked if this could be backed for now due to bug 720393, hope this was ok :-)

https://hg.mozilla.org/mozilla-central/rev/9b069a37f58f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla12 → ---
(Assignee)

Comment 4

6 years ago
I'm surprised that this bug caused bug 720393 because Jamie said embed relations are used for plugin stuffs only so it shouldn't lead to issues observed in bug 720393. Moreover I don't see any changes in behavior (at least prior to bug 591363 which broke it).

I pushed try server build https://tbpl.mozilla.org/?tree=Try&rev=9c9d74894bca. Marco, when it's ready please try it.
(Assignee)

Comment 5

6 years ago
try server build link http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/surkov.alexander@gmail.com-9c9d74894bca

Comment 6

6 years ago
Well, the observation is completely confirmed: I had the issues with this bug in, with it backed out, the situation returned to normal. There were two nightlies built on that day, the first with, the second without the patch after I identified it as being the guilty part. So the backout definitely fixed it.

Comment 7

6 years ago
I'm also seeing situations where the first tab document is returned, even if another tab is active. Is this related or should I file another bug?
(Assignee)

Comment 8

6 years ago
(In reply to James Teh [:Jamie] from comment #7)
> I'm also seeing situations where the first tab document is returned, even if
> another tab is active. Is this related or should I file another bug?

for the record: as I said on irc it's regression from bug 591363.

Comment 9

6 years ago
(In reply to alexander :surkov from comment #8)
> > I'm also seeing situations where the first tab document is returned, even if
> > another tab is active.
> for the record: as I said on irc it's regression from bug 591363.
I can confirm this is fixed by this patch.

Marco, I can't reproduce bug 720393 with this try build. I tried with the NVDA Snapshots page (which contains an iframe):
http://www.nvda-project.org/snapshots/
I moved to one of the download links within the iframe. I also tried Gmail and couldn't reproduce it their either. Scarily enough, I can't think of any pages with Facebook or Twitter gadgets on them right now (even though I see them all the time), so haven't tested that yet.
Strange, I did see it with every try in that short-lived nightly build, and that was, indeed, the only patch that landed. And it had to be a focused item inside. A difference may be that here, there's a lot of test and stuff that comes before the first focusable item, whereas with Twitter widgets the focusable item comes first thing inside those iframes.
(Assignee)

Comment 11

6 years ago
Marco, do you see any problems with try server build?
(In reply to alexander :surkov from comment #11)
> Marco, do you see any problems with try server build?

No, this latest try-server build is fine.
(Assignee)

Comment 13

6 years ago
Ok, I'll land it then again
(Assignee)

Comment 14

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/c75743aa5bce
https://hg.mozilla.org/mozilla-central/rev/c75743aa5bce
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Depends on: 725647
Flags: in-testsuite+
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.