707763 - mozdevice needs tests

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

Currently https://github.com/mozilla/mozbase/tree/master/mozdevice has
no tests.  Tests should be written to test basic functionality.

Comment 1

[cmtalbert]

There are a bunch of devicemanager tests living over here: http://hg.mozilla.org/automation/remote-testing/file/6b8020ffa955/tests

Comment 2

[William Lachance (:wlach)]

I added a basic test for devicemanagerSUT:

https://github.com/mozilla/mozbase/commit/eaf62c5b1e8d1a26c4a0407e3a58ba5c0d715eff

It uses a mock object for the agent, so as not to require a physical device to be connected to the machine. This strategy obviously won't work for devicemanagerADB... not really sure what to do there (I guess we could generate a fake adb executable...).

I'd like to get some tests going for devicemanagerADB, as well as make sure we're testing all the basic functionality, before closing this bug.

Comment 3

[Jeff Hammel]

It seems we have tests now.  Can/should we close?

Comment 4

[Mark Côté [:mcote]]

We have no tests for devicemanagerADB yet. I'd be okay filing a separate bug for that.

Comment 5

[Mark Côté [:mcote]]

At the moment, it would be rather difficult to write tests for DeviceManagerADB; we'd either have to create a mock adb utility or a mock adb server.  wlach suggested rewriting DeviceManagerADB to speak the adb protocol directly, which would allow us to use the same type of system that the SUT tests use, and it would also improve performance.  I filed bug 880362 for that, and will close this bug.