707902 - [ASC BUG] ASC asserts if a float4 value is present in an imported constant pool

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect, P2)

Description

[Lars T Hansen]

src/java/macromedia/abc/AbcParser.java:

In private Node getInitValueNode(int valueID,int kind):

   case ActionBlockConstants.CONSTANT_Float4:
     if(Features.FUTURE_ABC){
       assert false : "not yet implemented";
       ...

Comment 1

[Lars T Hansen]

Test case:  Compile this with -abcfuture (imp.as):

package
{
  function f(x:float4 = float4(1,2,3,4)) { return x }
}

Then import it:

-import imp.as

and we hit the assertion:

Exception in thread "main" java.lang.AssertionError: not yet implemented
	at macromedia.abc.AbcParser.getInitValueNode(AbcParser.java:522)
	at macromedia.abc.AbcParser.parseOptionalParams(AbcParser.java:608)
	at macromedia.abc.AbcParser.methodTrait(AbcParser.java:351)
	at macromedia.abc.AbcParser.parseTraits(AbcParser.java:967)
	at macromedia.abc.AbcParser.parseScript(AbcParser.java:1062)
	at macromedia.abc.AbcParser.parseAbc(AbcParser.java:92)
	at macromedia.abc.AbcParser.parseAbc(AbcParser.java:64)
	at macromedia.asc.embedding.Compiler.compile(Compiler.java:104)
	at macromedia.asc.embedding.Compiler.doCompile(Compiler.java:410)
	at macromedia.asc.embedding.Compiler.doCompile(Compiler.java:614)
	at macromedia.asc.embedding.Main.handleFile(Main.java:562)
	at macromedia.asc.embedding.Main.main(Main.java:368)

Comment 2

[Lars T Hansen]

Similar problem with getInitValue(), same file.

Comment 3

[Lars T Hansen]

(In reply to Lars T Hansen from comment #2)
> Similar problem with getInitValue(), same file.

Careless reading on my part; getInitValue appears to be OK.

Comment 4

[Lars T Hansen]

changeset:   80:7ff86ad975db
tag:         tip
user:        Lars T Hansen <[e-mail]>
date:        Wed Dec 07 15:32:37 2011 +0100
summary:     Fix 707902 - [ASC BUG] ASC asserts if a float4 value is present in an imported constant pool

test cases in tr-float, with updated asc.jar:

changeset:   7047:40813cd9f9b3
tag:         tip
parent:      7044:0a7f2fa8123c
parent:      7046:5a46791ba98e
user:        Lars T Hansen <[e-mail]>
date:        Wed Dec 07 15:34:24 2011 +0100
summary:     merged

Comment 5

[Tamarin Bot]

changeset: 7084:5d6d7c17055d
user:      Brent Baker <[e-mail]>
summary:   Workaround: Modify how the acceptance media is generated by the build system by reverting any changes to the acceptance directory after removing all *.abc files, this will actually allow *.abc files to be checked into the directory. This workaround is currently required for bug# 707902

http://hg.mozilla.org/tamarin-redux/rev/5d6d7c17055d