707913 - No Comply demo doesn't work

Status: RESOLVED INVALID

(Web Compatibility :: Site Reports, defect)

Description

[JK]

Error: uncaught exception: [Exception... "Not enough arguments [nsIDOMWindow.mozRequestAnimationFrame]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: https://developer.mozilla.org/media/uploads/demos/p/a/paulrouget/48e4f7c1e4f72277868270f10ea80ed8/no-comply_1322595143_demo_package/sequences.js :: <TOP_LEVEL> :: line 387"  data: no]

Error: uncaught exception: [Exception... "Not enough arguments [nsIDOMWindow.mozRequestAnimationFrame]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: https://developer.mozilla.org/media/uploads/demos/p/a/paulrouget/48e4f7c1e4f72277868270f10ea80ed8/no-comply_1322595143_demo_package/sequences.js :: startDemoInterval :: line 461"  data: no]

Regression range:

Good: http://hg.mozilla.org/mozilla-central/rev/bc48009a6bbb

Bad: http://hg.mozilla.org/mozilla-central/rev/cc94a16983b0

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bc48009a6bbb&tochange=cc94a16983b0

Comment 1

[JK]

Bug 704171 - Remove the no-argument form of requestAnimationFrame 

Done intentionally?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to JK from comment #1)
> Bug 704171 - Remove the no-argument form of requestAnimationFrame 
> 
> Done intentionally?

Yeah.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yep, this is using a Gecko-only feature that we removed.

Comment 4

[Paul Rouget [:paul]]

@dmose, @cj, can you please look at this?

Comment 5

[Charles J. Cliffe]

Hmm, I've never used it in this fashion myself -- I think Dave did the mozRequestAnimationFrame patch.  

What's the difference here? -- is it just that the mozRequestAnimationFrame function used to call back to wherever it was called from?

If so I should be able to patch that up quickly.

Comment 6

[Boris Zbarsky [:bzbarsky]]

It used to fire the MozBeforePaint event.  So if you're adding functions as listeners for that event, you should just pass those same functions directly to mozRequestAnimationFrame.

Comment 7

[Charles J. Cliffe]

The MozBeforePaint and empty mozRequestAnimationFrame is now fixed up in the latest commit at: https://github.com/cjcliffe/NoComply/commit/01d994e440cc12b5c5fcaa56b4476c6a05fb09db

Whatever was broken in Firefox with workers between 7.x and 8.x still affects it though so it will halt before the tunnel scene.  I don't know enough about debugging the workers in that code so it will remain broken until someone can investigate.

Comment 8

[Adam Stevenson [:adamopenweb]]

Still broken. Moving to desktop component.

Comment 9

[Karl Dubost💡 :karlcow]

This page
https://developer.mozilla.org/en-US/demos/detail/no-comply/

now redirects to
https://developer.mozilla.org/en-US/docs/Web/Demos_of_open_web_technologies

Closing as invalid.