Tags should avoid results overhead

RESOLVED FIXED in mozilla11

Status

()

Toolkit
Places
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({perf})

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

While it's the cleaner way to do that with the current API, results have an overhead we can't currently pay on hot paths doing lots of tags operations.
It's just simpler to use queries, this also allows to reduce the queries traffic.
Created attachment 579502 [details] [diff] [review]
patch v1.0

Use direct queries, and some caching trick
Attachment #579502 - Flags: review?(dietrich)
Comment on attachment 579502 [details] [diff] [review]
patch v1.0

Review of attachment 579502 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.
Attachment #579502 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae823406bcb3
Target Milestone: --- → mozilla11

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/ae823406bcb3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.