refactor the ifdefs in nsStackWalk.cpp

RESOLVED FIXED in mozilla12

Status

RESOLVED FIXED
7 years ago
9 months ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla12
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

The ifdefs in nsStackWalk.cpp are fairly hard to read and have duplicated code. The attached patch factors them to be a bit more readable.

https://tbpl.mozilla.org/?tree=Try&rev=170707a6671b
Attachment #579393 - Flags: review?(ehsan)

Comment 1

7 years ago
Comment on attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

This looks good, but to be honest I've never seen "defined" being used in a macro expansion (maybe that's just me), so let's ask dbaron to take a look at this as well.
Attachment #579393 - Flags: review?(ehsan) → review?(dbaron)
Comment on attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

r=dbaron, except I don't like the names -- the "_WITH_UNWIND" naming seems easily confused with "HAVE__UNWIND_BACKTRACE", when they really mean different things.  Maybe change X_WITH_UNWIND to NSSTACKWALK_SUPPORTS_X or something similar (for the three values of X)?

Also, in the future, please include commit messages in patches posted for review.
Attachment #579393 - Flags: review?(dbaron) → review+

Comment 4

7 years ago
https://hg.mozilla.org/mozilla-central/rev/6707b2415598
Assignee: nobody → respindola
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.