Last Comment Bug 708031 - refactor the ifdefs in nsStackWalk.cpp
: refactor the ifdefs in nsStackWalk.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla12
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-06 11:42 PST by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2012-02-01 14:00 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
refactor the ifdefs in nsStackWalk.cpp (3.39 KB, patch)
2011-12-06 11:42 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
dbaron: review+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-12-06 11:42:40 PST
Created attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

The ifdefs in nsStackWalk.cpp are fairly hard to read and have duplicated code. The attached patch factors them to be a bit more readable.

https://tbpl.mozilla.org/?tree=Try&rev=170707a6671b
Comment 1 :Ehsan Akhgari 2011-12-21 14:34:05 PST
Comment on attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

This looks good, but to be honest I've never seen "defined" being used in a macro expansion (maybe that's just me), so let's ask dbaron to take a look at this as well.
Comment 2 David Baron :dbaron: ⌚️UTC+2 (review requests must explain patch) 2011-12-21 14:46:25 PST
Comment on attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

r=dbaron, except I don't like the names -- the "_WITH_UNWIND" naming seems easily confused with "HAVE__UNWIND_BACKTRACE", when they really mean different things.  Maybe change X_WITH_UNWIND to NSSTACKWALK_SUPPORTS_X or something similar (for the three values of X)?

Also, in the future, please include commit messages in patches posted for review.
Comment 3 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-12-22 08:12:36 PST
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=6707b2415598
Comment 4 Ed Morley [:emorley] 2011-12-23 19:00:53 PST
https://hg.mozilla.org/mozilla-central/rev/6707b2415598

Note You need to log in before you can comment on or make changes to this bug.