708031 - refactor the ifdefs in nsStackWalk.cpp

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: refactor the ifdefs in nsStackWalk.cpp

The ifdefs in nsStackWalk.cpp are fairly hard to read and have duplicated code. The attached patch factors them to be a bit more readable.

https://tbpl.mozilla.org/?tree=Try&rev=170707a6671b

Comment 1

[(no longer active)]

Comment on attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

This looks good, but to be honest I've never seen "defined" being used in a macro expansion (maybe that's just me), so let's ask dbaron to take a look at this as well.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 579393 [details] [diff] [review]
refactor the ifdefs in nsStackWalk.cpp

r=dbaron, except I don't like the names -- the "_WITH_UNWIND" naming seems easily confused with "HAVE__UNWIND_BACKTRACE", when they really mean different things.  Maybe change X_WITH_UNWIND to NSSTACKWALK_SUPPORTS_X or something similar (for the three values of X)?

Also, in the future, please include commit messages in patches posted for review.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=6707b2415598

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6707b2415598