Closed
Bug 708073
Opened 13 years ago
Closed 11 years ago
Sync set-up wizard should respect platform theme conventions
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 665342
People
(Reporter: Margaret, Assigned: harshit080)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug] [mentor=margaret] [lang=xul] [lang=css])
Attachments
(2 files)
The sync set-up wizard has a light blue footer section on all platforms, but this is a Windows-specific theme convention, so it should be fixed on OSX and Linux. I'm no UX expert, but I imagine we'd want styles similar to the dialog from bug 596343. There are screenshots in there that show what the footer style looks like on different platforms. Ally, if you're too busy to deal with this, maybe this could make for a good [good first bug].
Comment 1•13 years ago
|
||
As the person who implemented the wizard in its current theme and incarnation, I plead guilty here. (Though, to my defence, Faaborg never delivered OS X mockups for these kinds of wizards until bug 596343 came along.) I completely agree with this bug. Ideally we would share the same CSS as the wizard from bug 596343, but at least the same look'n'feel. This seems like an easy enough task for somebody who knows a bit of XUL and CSS styling.
Blocks: 591122
Whiteboard: [good first bug]
Updated•13 years ago
|
Whiteboard: [good first bug] → [good first bug] [lang=xul] [lang=css]
Reporter | ||
Comment 2•12 years ago
|
||
Moving this to Firefox:Theme, since this is really a theme bug.
Component: Firefox Sync: UI → Theme
Product: Mozilla Services → Firefox
QA Contact: sync-ui → theme
Version: unspecified → Trunk
Comment 3•12 years ago
|
||
Philipp, please correct me if I'm wrong.
Whiteboard: [good first bug] [lang=xul] [lang=css] → [good first bug] [mentor=philikon] [lang=xul] [lang=css]
Hi.. I am new here and would like to help out. Could someone guide me how to proceed with this ?
Comment 5•12 years ago
|
||
Dolske/Gavin is there someone better than philikon to mentor here?
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Reporter | ||
Comment 8•12 years ago
|
||
I can help mentor! I'd be excited for someone to fix this pet peeve of mine :) saran, do you have a local build of Firefox set up? Also, what platform (OSX/Windows/Linux) are you using to develop this change? As philikon mentioned in comment 1, we can probably copy CSS that was added for the dialog in bug 596343. The styles for the sync pane are located in: http://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/preferences/preferences.css http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/preferences/preferences.css http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/preferences/preferences.css Feel free to join #fx-team on irc.mozilla.org to ask questions or look for help getting set up. There are generally always people in there willing to help! Also, I'm cc'ing Jared to check in on the status of in-content preferences. If there's an actionable plan to turn those on by default, your time might be better spent helping out with that project, since this UI will go away when that happens.
Whiteboard: [good first bug] [mentor=philikon] [lang=xul] [lang=css] → [good first bug] [mentor=margaret] [lang=xul] [lang=css]
Comment 9•12 years ago
|
||
margaret++. Let us know if you want feedback from the s-i(formerly sync) team. :saran, welcome & you're in good hands; margaret is pretty awesome.
Comment 10•12 years ago
|
||
In-content preferences is still a work-in-progress and likely not to make it in time for Firefox 18. If we can get this bug fixed in time for Fx18 that would be great!
Assignee: nobody → ksk.3393
Status: NEW → ASSIGNED
Comment 11•12 years ago
|
||
I went through the css files mentioned , but couldn't exactly find which style is responsible for the footer. Could you guide me on what I am supposed to be looking for ?
Assignee | ||
Comment 12•11 years ago
|
||
hey sir, can i contribute for the above bug,can you assign it to me ?
Updated•11 years ago
|
Flags: needinfo?(margaret.leibovic)
Reporter | ||
Comment 13•11 years ago
|
||
(In reply to harsh chhabra from comment #12) > can i contribute for the above bug,can you assign it to me ? Sure, I just assigned the bug to you. Do you understand what needs to be done to fix this bug? The MXR links in the comments above are out of date at this point, but you should be able to do a file search to find the appropriate preferences.css files. If I were you, I'd just start with the theme of whatever platform you're developing on. We can always land that, then fix other platforms separately to scale down the scope of this bug. Feel free to join #fx-team on irc.mozilla.org if you have questions! The people in there are nice and willing to help :) Saran, did you ever manage to make any progress on this? I think I remember us discussing it on IRC when you were working on it. Maybe if you have a WIP ("work in progress") patch somewhere on your computer, you could post it to this bug to help out Harsh.
Assignee: ksk.3393 → harshit080
Flags: needinfo?(margaret.leibovic) → needinfo?(ksk.3393)
Assignee | ||
Comment 14•11 years ago
|
||
margaret instead of preferance.css as described above i studied syncSetup.css http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/syncSetup.css (for linux) http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/syncSetup.css (for osx) and i found "background-color :Window" is defined, so i guess this bug may be the reason of that. if so what color it should be ? Or if it is not so please guid me to get it.
Updated•11 years ago
|
Flags: needinfo?(margaret.leibovic)
Comment 15•11 years ago
|
||
Hi Harsh, thanks for looking in to that. The preferences.css files that were mentioned above were moved to a new location, hence why those links no longer show a CSS file. I did some deeper digging and it appears that this bug was just fixed recently by bug 665342. The accepted change was to use a very transparent black, rgba(0,0,0,.1), for the background-color.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(ksk.3393)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•