708095 - cfx on Windows using 64bit Python fails to find firefox when installed to a non-standard location

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

in a 64bit Python, cfx fails to locate firefox in the registry.  If FF is installed to a "standard" location it often does locate it as it sniffs out some standard locations if the registry lookup fails, but I've got it installed in a non-standard location (mainly to avoid the UAC prompts to install updates).

Will attach a pull-request.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/289

Pointer to Github pull-request

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/289#

Pointer to Github pull-request

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 579465 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/289#

Looks good, r=myk, feel free to check it in.

But we should also get ctalbert's review and then check it in upstream so other mozrunner users get the fix and it's easier for us to move to a newer version of mozrunner.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 579465 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/289#

Erm, I hear upstream is actually heading in the other direction, toward removing all binary detection from their codebase.  We still want binary detection in our copy, so we should still land this change in the SDK repository; but no need for Clint to review it for potential inclusion upstream.

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a013c112563d864ba478fc221be09acaf3854b84
Merge pull request #289 from mhammond/bug/708095-look-in-32bit-registry

fix bug 708095 - look for the binary in both 64bit and 32bit registry hives; r=@mykmelez