7081 - Form submission through ENTER in a text field broken on win32/gtk

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[David Hyatt]

On both Windows and GTK, if you go to yahoo.com and type something into
the text field and hit enter, nothing happens.  The form should be
submitted (without having to click on the button).

On Windows, the TextWindowProc is filtering out return key events.  I'm not
sure what GTK is doing.

Comment 1

[karnaze (gone)]

Tom, can you take a look. I recently reassigned another similar bug to you, but
can't remember the number. nsFormControlFrame::HandleEvent is no longer getting
enter pressed key events.

Comment 2

[David Hyatt]

A couple of comments.

(1) The EnterPressed function in nsFormControlFrame::HandleEvent was
deliberately commented out, since it tries to submit a form (and this
was busting up XUL when no action was specified).  The build guys decided
to comment it out and then worry about fixing the submit problem post-M6.

(2) Win32 filters out enter key presses in the TextWindowProc function,
so even if you do put the EnterPressed function back into HandleEvent, it
still won't ever get fired on Win32.

(3) GTK also never fires EnterPressed, but I don't know enough about GTK
to know why.

Comment 3

[David Hyatt]

See bug 7083 for the related bug regarding the action problem in forms (the
reason the build guys commented out EnterPressed in the first place).

Comment 4

[Eli Goldberg]

Please note that this also takes place on the 1999/06.01/09:00 Mac OS build.
Changing platform to 'All' and CC:ing self.

Comment 5

[Crysgem]

As of the Lose98 M7 Apprunner build, this flaw appears sealed (tested at
http://www.google.com/, http://www.yahoo.com/, and http://www.linux.org/). What
say the denizens of other platforms?

Comment 6

[cpratt]

crysgem, did you mean Windows 98? If you did, please refer to Windows by its
proper name in the future. Bugzilla is not the place for disparaging remarks
about other companies' products.

This appears fixed on Windows NT 4 SP 5. Will verify on Mac OS and close this
bug out by EOD 23.6.99.

Comment 7

[Crysgem]

*** Bug 6520 has been marked as a duplicate of this bug. ***

Comment 8

[Eli Goldberg]

joki & cpratt, as part of verifying 6221, I note that this bug appears fixed on:
       1999090609 Mac OS (8.6)
       1999090609 Win32 (NT 4.0 SP3)
       1999090708 Linux (RH 6.0/GNOME)

Comment 9

[cpratt]

Seems to be working on the 1999090708 build, NT 5.

Comment 10

[joki (gone)]

I agree.  I believe this has been fixed.