Closed Bug 70810 Opened 19 years ago Closed 19 years ago

[XUL Syntax] Change tab syntax

Categories

(Core :: XUL, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.0

People

(Reporter: hyatt, Assigned: maolson)

References

Details

(Whiteboard: [XUL1.0])

Attachments

(5 files)

<tabconrol> --> <tabbox>
<tabbox> --> <tabs>
<tabpanel> --> <tabpanels>
<tabpage> --> <tabpanel>

Make a simplified version that allows label attributes to be put on <tabpanel>. 
The tabs can be anonymously built from the labels.
Status: NEW → ASSIGNED
Whiteboard: [XUL1.0]
Target Milestone: --- → mozilla1.0
Blocks: 70753
OS: Windows 2000 → All
=> me
Assignee: hyatt → ben
Status: ASSIGNED → NEW
Any reason this couldn't be done in two passes, one for the name changes and one
for the syntax updates?  I'll take the renaming and we can go from there, unless
someone objects.
I'll take this.
Assignee: ben → maolson
Two passes would be fun.
The attached patch covers everything, including security (i'll make a separate
patch for that when the time comes).  I'm building to test currently.

<tabpage> (now <tabpanel>) wasn't used anywhere in xul or css, but i changed the
few references anyway.
Status: NEW → ASSIGNED
hyatt, ben; feedback, r/sr?
sr=hyatt

We'll need a carpool again for this one.
I'll look at commercial on this.
cc'ing leaf for carpool magic, possibly experimental build magic also.
Ben, I'd really appreciate if you could finish reviewing this, it would be nice
to get into 0.9.

hyatt - are you sure we need a carpool for this?  This is relatively contained
and kerz has my back for netscape's commercial tree. (You do have my back right
kerz?)
mao, this looks great. Sorry for taking so long to get to this. 
r=ben

Don't think we need a carpool for this, if it's done at a low traffic time 
(e.g. at night). I've done this sort of change before with myself covering 
comm. and caused no problems. 

fix checked in.  bryner took care of security, rumor has it kerz handled ns' tree.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.