Closed
Bug 708125
Opened 13 years ago
Closed 13 years ago
OGL Layers thrashes current context in UpdateSurface and RenderLayer
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file)
3.42 KB,
patch
|
jgilbert
:
review-
|
Details | Diff | Splinter Review |
For the shared-texture path:
In UpdateSurface we currently switch to the layer GLContext, even if it's not necessary.
In RenderLayer, we switch to the WebGL GLContext to resolve, then back again to the layer GLContext for rendering.
This is possibly adding an extra context switch, when we could be doing all the work in the WebGL GLContext before moving on to the work on the layer GLContext.
Assignee | ||
Comment 1•13 years ago
|
||
This also moves the UpdateSurface code for resolving the buffer back to UpdateSurface, instead of where it is now in RenderLayer.
Attachment #579520 -
Flags: review?(bjacob)
Updated•13 years ago
|
Attachment #579520 -
Attachment is patch: true
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 579520 [details] [diff] [review]
Reduce current context thrashing in OGL Layers
Review of attachment 579520 [details] [diff] [review]:
-----------------------------------------------------------------
Patch no longer necessary after bug 711649.
Attachment #579520 -
Flags: review?(bjacob) → review-
Comment 3•13 years ago
|
||
Fixed by bug 711649
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•