OGL Layers thrashes current context in UpdateSurface and RenderLayer

RESOLVED FIXED in mozilla11

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
For the shared-texture path:
In UpdateSurface we currently switch to the layer GLContext, even if it's not necessary.
In RenderLayer, we switch to the WebGL GLContext to resolve, then back again to the layer GLContext for rendering.

This is possibly adding an extra context switch, when we could be doing all the work in the WebGL GLContext before moving on to the work on the layer GLContext.
(Assignee)

Comment 1

6 years ago
Created attachment 579520 [details] [diff] [review]
Reduce current context thrashing in OGL Layers

This also moves the UpdateSurface code for resolving the buffer back to UpdateSurface, instead of where it is now in RenderLayer.
Attachment #579520 - Flags: review?(bjacob)
Attachment #579520 - Attachment is patch: true
(Assignee)

Comment 2

5 years ago
Comment on attachment 579520 [details] [diff] [review]
Reduce current context thrashing in OGL Layers

Review of attachment 579520 [details] [diff] [review]:
-----------------------------------------------------------------

Patch no longer necessary after bug 711649.
Attachment #579520 - Flags: review?(bjacob) → review-
(Assignee)

Updated

5 years ago
Depends on: 711649
Fixed by bug 711649
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.