Remove homepage preference

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 579590 [details] [diff] [review]
patch

Since setting the homepage preference to anything other than the native about:home makes startup more difficult, we are (for now) getting rid of this preference.
Attachment #579590 - Flags: review?(doug.turner)

Comment 1

6 years ago
Comment on attachment 579590 [details] [diff] [review]
patch

This is fine.  Leave the string in the code.  I am not sure if we want to just keep it (maybe we want to add this back in the short term, and having it localized everywhere would be great).  File a followup to remove it and cc/ pike and mfinkle for input.
Attachment #579590 - Flags: review?(doug.turner) → review+

Updated

6 years ago
Whiteboard: [QA+]
Priority: -- → P1

Updated

6 years ago
Assignee: nobody → bnicholson

Comment 2

6 years ago
Not a friend to remove strings for bugs that have nothing to do with it, in this case, you're removing the language selector string? I'd leave them all untouched, and file bugs for the language string and the homepage strings independently.
(Assignee)

Comment 3

6 years ago
Filed bug 708806 and bug 708808 for string removal.

Landed: http://hg.mozilla.org/integration/mozilla-inbound/rev/27eb5d3609a1

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/27eb5d3609a1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Retested with:
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111212 Firefox/11.0a1 Fennec/11.0a1
HTC Desire Z (Android 2.3)

Homepage preference is no longer listed in Preferences.
Verifying bug.
Status: RESOLVED → VERIFIED
Whiteboard: [QA+]
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.