Closed Bug 708185 Opened 8 years ago Closed 8 years ago

Remove homepage preference

Categories

(Firefox for Android :: General, defect, P1)

All
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: bnicholson, Assigned: bnicholson)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Since setting the homepage preference to anything other than the native about:home makes startup more difficult, we are (for now) getting rid of this preference.
Attachment #579590 - Flags: review?(doug.turner)
Comment on attachment 579590 [details] [diff] [review]
patch

This is fine.  Leave the string in the code.  I am not sure if we want to just keep it (maybe we want to add this back in the short term, and having it localized everywhere would be great).  File a followup to remove it and cc/ pike and mfinkle for input.
Attachment #579590 - Flags: review?(doug.turner) → review+
Whiteboard: [QA+]
Priority: -- → P1
Assignee: nobody → bnicholson
Not a friend to remove strings for bugs that have nothing to do with it, in this case, you're removing the language selector string? I'd leave them all untouched, and file bugs for the language string and the homepage strings independently.
https://hg.mozilla.org/mozilla-central/rev/27eb5d3609a1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Retested with:
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111212 Firefox/11.0a1 Fennec/11.0a1
HTC Desire Z (Android 2.3)

Homepage preference is no longer listed in Preferences.
Verifying bug.
Status: RESOLVED → VERIFIED
Whiteboard: [QA+]
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.