Last Comment Bug 708274 - Remove 2 deprecated PR_ABS() uses in MailNews Core
: Remove 2 deprecated PR_ABS() uses in MailNews Core
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
-- minor (vote)
: Thunderbird 11.0
Assigned To: :aceman
Depends on: 518502
Blocks: 707396
  Show dependency treegraph
Reported: 2011-12-07 09:17 PST by Serge Gautherie (:sgautherie)
Modified: 2011-12-20 17:29 PST (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (1.90 KB, patch)
2011-12-12 11:09 PST, :aceman
standard8: review+
Details | Diff | Splinter Review

Description User image Serge Gautherie (:sgautherie) 2011-12-07 09:17:09 PST

Comment 1 User image :aceman 2011-12-11 07:51:18 PST
db/msgdb/src/nsMailDatabase.cpp:        *aResult = PR_ABS((PRInt32) (actualFolderTimeStamp - folderDate)) <= gTimeStampLeeway;
extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:        double distance = PR_ABS(prob - 0.5);

And what would be the proper replacement?
Comment 2 User image Serge Gautherie (:sgautherie) 2011-12-11 08:06:40 PST
(In reply to :aceman from comment #1)
> And what would be the proper replacement?

Comment 3 User image :aceman 2011-12-11 08:41:39 PST
Thanks, that was my guess too, I was however stopped by the fact that NS_ABS is used nowhere in mailnews. It is used only in mozilla core.

So I will use it.
Comment 4 User image :aceman 2011-12-12 00:00:12 PST
I will post a patch as soon I can compile test it, after the current tree breakage will be fixed by somebody (NSReg.h is missing).
Comment 5 User image :aceman 2011-12-12 11:09:27 PST
Created attachment 580974 [details] [diff] [review]
Comment 6 User image Siddharth Agarwal [:sid0] (inactive) 2011-12-20 03:19:18 PST
Comment 7 User image Serge Gautherie (:sgautherie) 2011-12-20 17:29:48 PST
V.Fixed, per MXR search.

Note You need to log in before you can comment on or make changes to this bug.