The default bug view has changed. See this FAQ.

Remove 2 deprecated PR_ABS() uses in MailNews Core

VERIFIED FIXED in Thunderbird 11.0

Status

MailNews Core
Backend
--
minor
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: aceman)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 11.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

5 years ago
Whiteboard: [good first bug]
(Assignee)

Comment 1

5 years ago
db/msgdb/src/nsMailDatabase.cpp:        *aResult = PR_ABS((PRInt32) (actualFolderTimeStamp - folderDate)) <= gTimeStampLeeway;
extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:        double distance = PR_ABS(prob - 0.5);

And what would be the proper replacement?
(Reporter)

Comment 2

5 years ago
(In reply to :aceman from comment #1)
> And what would be the proper replacement?

NS_ABS()
(Assignee)

Comment 3

5 years ago
Thanks, that was my guess too, I was however stopped by the fact that NS_ABS is used nowhere in mailnews. It is used only in mozilla core.

So I will use it.
(Assignee)

Comment 4

5 years ago
I will post a patch as soon I can compile test it, after the current tree breakage will be fixed by somebody (NSReg.h is missing).
Assignee: nobody → acelists
(Assignee)

Comment 5

5 years ago
Created attachment 580974 [details] [diff] [review]
patch
Attachment #580974 - Flags: review?(mbanner)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Attachment #580974 - Flags: review?(mbanner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: [good first bug]
https://hg.mozilla.org/comm-central/rev/fbe171af8a1e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
(Reporter)

Comment 7

5 years ago
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.