Closed
Bug 708572
Opened 13 years ago
Closed 13 years ago
Consider backing out bug 335998 from Beta/FF9
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: smaug, Unassigned)
References
Details
(Whiteboard: [qa?])
Attachments
(1 file, 1 obsolete file)
|
22.92 KB,
patch
|
jst
:
review+
Ms2ger
:
review+
bzbarsky
:
review+
jst
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
See Bug 702813.
This is similar to Bug 674276. The patch is like for FF8, but
parentNode traversing was moved to nsINode.
https://tbpl.mozilla.org/?tree=Try&rev=c757fdfb3a79
Attachment #579998 -
Flags: review?(jst)
|
Reporter | |
Comment 1•13 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=702813#c13
For FF9 the backout is actually easy.
For FF10, not as easy.
tracking-firefox9:
--- → ?
|
|
Reporter | |
Comment 2•13 years ago
|
||
hmm, there has been few changes which need a null check :(
|
|
Reporter | |
Comment 3•13 years ago
|
||
I went through GetOwnerDoc() calls and noticed two cases added in FF9 which
don't have null check: onfoo handling and nsGenericDOMDataNode warnings.
I'm not yet 100% sure we should take this, but we don't have much time to decide.
https://tbpl.mozilla.org/?tree=Try&rev=e9ce6e2f8ad5
Attachment #579998 -
Attachment is obsolete: true
Attachment #579998 -
Flags: review?(jst)
Attachment #580015 -
Flags: review?(jst)
Attachment #580015 -
Flags: review?(bzbarsky)
Attachment #580015 -
Flags: review?(Ms2ger)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 580015 [details] [diff] [review]
patch
r=me on the event bits
Attachment #580015 -
Flags: review?(bzbarsky) → review+
|
||
Comment 5•13 years ago
|
||
Comment on attachment 580015 [details] [diff] [review]
patch
The nsGenericDOMDataNode warning bits look good.
Attachment #580015 -
Flags: review?(Ms2ger) → review+
|
|
Reporter | |
Updated•13 years ago
|
Attachment #580015 -
Flags: approval-mozilla-beta?
|
||
Updated•13 years ago
|
Summary: Consider to backout bug 335998 from Beta/FF9 → Consider backing out bug 335998 from Beta/FF9
|
||
Comment 7•13 years ago
|
||
Comment on attachment 580015 [details] [diff] [review]
patch
r=jst and approved for beta per todays release driver meeting.
Attachment #580015 -
Flags: review?(jst)
Attachment #580015 -
Flags: review+
Attachment #580015 -
Flags: approval-mozilla-beta?
Attachment #580015 -
Flags: approval-mozilla-beta+
|
|
Reporter | |
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•13 years ago
|
status-firefox9:
--- → fixed
Is there something QA can do to verify this backout?
Whiteboard: [qa?]
|
|
Reporter | |
Comment 10•13 years ago
|
||
http://home.arcor.de/martin.honnen/mozillaBugs/domLevel2/parentNodeProblem1.html should fail.
At some point the parentNode should change to null.
|
|
Reporter | |
Updated•13 years ago
|
Blocks: strongparent
|
|
Reporter | |
Comment 11•13 years ago
|
||
And backed out the backout :(
https://hg.mozilla.org/releases/mozilla-release/rev/b78fe362789b
Resolution: FIXED → WONTFIX
|
||
Comment 12•13 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #0)
> Created attachment 579998 [details] [diff] [review]
> patch
>
> See Bug 702813.
>
> This is similar to Bug 674276. The patch is like for FF8, but
> parentNode traversing was moved to nsINode.
>
>
> https://tbpl.mozilla.org/?tree=Try&rev=c757fdfb3a79
|
Assignee | |
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•