Consider backing out bug 335998 from Beta/FF9

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
8 years ago
3 months ago

People

(Reporter: smaug, Unassigned)

Tracking

unspecified
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox9+ fixed)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch patch (obsolete) — Splinter Review
See Bug 702813.

This is similar to Bug 674276. The patch is like for FF8, but
parentNode traversing was moved to nsINode.


https://tbpl.mozilla.org/?tree=Try&rev=c757fdfb3a79
Attachment #579998 - Flags: review?(jst)
https://bugzilla.mozilla.org/show_bug.cgi?id=702813#c13
For FF9 the backout is actually easy.
For FF10, not as easy.
hmm, there has been few changes which need a null check :(
Posted patch patchSplinter Review
I went through GetOwnerDoc() calls and noticed two cases added in FF9 which
don't have null check: onfoo handling and nsGenericDOMDataNode warnings.

I'm not yet 100% sure we should take this, but we don't have much time to decide.
https://tbpl.mozilla.org/?tree=Try&rev=e9ce6e2f8ad5
Attachment #579998 - Attachment is obsolete: true
Attachment #579998 - Flags: review?(jst)
Attachment #580015 - Flags: review?(jst)
Attachment #580015 - Flags: review?(bzbarsky)
Attachment #580015 - Flags: review?(Ms2ger)
Comment on attachment 580015 [details] [diff] [review]
patch

r=me on the event bits
Attachment #580015 - Flags: review?(bzbarsky) → review+
Comment on attachment 580015 [details] [diff] [review]
patch

The nsGenericDOMDataNode warning bits look good.
Attachment #580015 - Flags: review?(Ms2ger) → review+
Code freeze is tomorrow 12/9. Please nominate for beta approval asap.
Attachment #580015 - Flags: approval-mozilla-beta?
Summary: Consider to backout bug 335998 from Beta/FF9 → Consider backing out bug 335998 from Beta/FF9
Comment on attachment 580015 [details] [diff] [review]
patch

r=jst and approved for beta per todays release driver meeting.
Attachment #580015 - Flags: review?(jst)
Attachment #580015 - Flags: review+
Attachment #580015 - Flags: approval-mozilla-beta?
Attachment #580015 - Flags: approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/1b302e06c6b1
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Is there something QA can do to verify this backout?
Whiteboard: [qa?]
http://home.arcor.de/martin.honnen/mozillaBugs/domLevel2/parentNodeProblem1.html should fail.
At some point the parentNode should change to null.
And backed out the backout :(
https://hg.mozilla.org/releases/mozilla-release/rev/b78fe362789b
Resolution: FIXED → WONTFIX

Comment 12

7 years ago
(In reply to Olli Pettay [:smaug] from comment #0)
> Created attachment 579998 [details] [diff] [review]
> patch
> 
> See Bug 702813.
> 
> This is similar to Bug 674276. The patch is like for FF8, but
> parentNode traversing was moved to nsINode.
> 
> 
> https://tbpl.mozilla.org/?tree=Try&rev=c757fdfb3a79
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.