708597 - Download toaster notification is displayed only for the first download

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111208 Firefox/11.0a1 Fennec/11.0a1
Device: Samsung Nexus S
OS: Android 2.3

Steps to reproduce:
1. Start application and go to ww.irs.gov
2. Download a file
3. Wait for download to finish
4. Download another file

Expected results:
 A system bar notification and a toaster notification is displayed "Download started..."

Actual results:
 A system bar notification is displayed, but toaster notification is not displayed.

Notes: User needs to restart Fennec for toaster notification to be displayed again.

Comment 1

[Martijn Wargers (dead)]

I don't see anything displayed in the system bar. Is this expected as of now?

The toaster notification is displayed every time, so I guess this bug has become worksforme?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #1)
> I don't see anything displayed in the system bar. Is this expected as of now?

Any file download should create a "progress" system notification and when completed, should have a system notification allowing you to open the file.

> The toaster notification is displayed every time, so I guess this bug has
> become worksforme?

Yes

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Found a code problem

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60937143195c

Comment 5

[Marco Bonardo [:mak] (Away 10-21 August)]

https://hg.mozilla.org/mozilla-central/rev/60937143195c

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585866 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: no notification for subsequent downloads
Testing completed (on m-c, etc.): baked
Risk to taking this patch (and alternatives if risky): none

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 585866 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f807d3438d0

Comment 9

[Carla Nadastean]

Verified with:
Aurora 11.0a2 (2012-01-08) HTC Desire Z (Android 2.3)
Nightly 12.0a1 (2012-01-08) HTc Desire Z (Android 2.3)

Download toaster notification is displayed each time a file is downloaded.