708613 - Move SplitView component in devtools/shared

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Cedric Vivier [:cedricv]]

Currently in devtools/styleeditor but this is a generic UI module that we intend to reuse for Scratchpad (see bug 708213) and other tools.

Let's move in in shared/ then.

Comment 1

[Cedric Vivier [:cedricv]]

Attachment: Move it.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 580036 [details] [diff] [review]
Move it.

+    content/browser/splitview.css                 (shared/splitview.css)
 *   content/browser/styleeditor.xul               (styleeditor/styleeditor.xul)
-    content/browser/splitview.css                 (styleeditor/splitview.css)

we should put this in content/browser/devtools/...

(and should probably move the scratchpad and associates there as well in a separate patch).

Comment 3

[Paul Rouget [:paul]]

Shouldn't we land this?

Comment 4

[Rob Campbell [:rc] (:robcee)]

probably!

Comment 5

[Cedric Vivier [:cedricv]]

Attachment: Same patch. Rebased against tip.

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/f96d6dd51d6c

Comment 7

[Rob Campbell [:rc] (:robcee)]

Backed out in:

https://hg.mozilla.org/integration/fx-team/rev/a89c7779fed4

see log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=8670802&tree=Fx-Team

Comment 8

[Cedric Vivier [:cedricv]]

Attachment: Add missing module install in shared/Makefile...

Comment 9

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/50cd93681c9b

Comment 10

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/50cd93681c9b

Comment 11

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 590096 [details] [diff] [review]
Add missing module install in shared/Makefile...

[Approval Request Comment]
Regression caused by (bug #): New feature.
User impact if declined: Addon Compatibility will be affected*
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): It appears large, but it's really just a file move.

* About Addon Compatibility.

Fx11 is the first version of Firefox with this new feature. The SplitView.jsm file is already being used by an addon we are about to include in the browser. Not having this in its ultimate destination makes using this shared component more difficult. We only realized the potential of having this as a shared library later in the development of Firefox 12, hence our late request.

There really is negligible impact to landing this in aurora. Really.