The default bug view has changed. See this FAQ.

Move SplitView component in devtools/shared

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cedricv, Assigned: cedricv)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Currently in devtools/styleeditor but this is a generic UI module that we intend to reuse for Scratchpad (see bug 708213) and other tools.

Let's move in in shared/ then.
(Assignee)

Comment 1

5 years ago
Created attachment 580036 [details] [diff] [review]
Move it.

Updated

5 years ago
Attachment #580036 - Flags: review?(rcampbell)
Comment on attachment 580036 [details] [diff] [review]
Move it.

+    content/browser/splitview.css                 (shared/splitview.css)
 *   content/browser/styleeditor.xul               (styleeditor/styleeditor.xul)
-    content/browser/splitview.css                 (styleeditor/splitview.css)

we should put this in content/browser/devtools/...

(and should probably move the scratchpad and associates there as well in a separate patch).
Attachment #580036 - Flags: review?(rcampbell) → review+

Comment 3

5 years ago
Shouldn't we land this?
probably!
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 5

5 years ago
Created attachment 589853 [details] [diff] [review]
Same patch. Rebased against tip.
Attachment #580036 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/f96d6dd51d6c
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Backed out in:

https://hg.mozilla.org/integration/fx-team/rev/a89c7779fed4

see log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=8670802&tree=Fx-Team
Whiteboard: [fixed-in-fx-team] → [backed-out]
(Assignee)

Comment 8

5 years ago
Created attachment 590096 [details] [diff] [review]
Add missing module install in shared/Makefile...
Attachment #589853 - Attachment is obsolete: true
Attachment #590096 - Flags: review?(rcampbell)
Attachment #590096 - Flags: review?(rcampbell) → review+
Whiteboard: [backed-out] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/50cd93681c9b
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/50cd93681c9b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 590096 [details] [diff] [review]
Add missing module install in shared/Makefile...

[Approval Request Comment]
Regression caused by (bug #): New feature.
User impact if declined: Addon Compatibility will be affected*
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): It appears large, but it's really just a file move.

* About Addon Compatibility.

Fx11 is the first version of Firefox with this new feature. The SplitView.jsm file is already being used by an addon we are about to include in the browser. Not having this in its ultimate destination makes using this shared component more difficult. We only realized the potential of having this as a shared library later in the development of Firefox 12, hence our late request.

There really is negligible impact to landing this in aurora. Really.
Attachment #590096 - Flags: approval-mozilla-aurora?
Attachment #590096 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.