708642 - Update Wordcode intepreter to handle float/float4

Status: VERIFIED FIXED

(Tamarin Graveyard :: Interpreter, defect, P4)

Description

[Virgil Palanciuc]

Wordcode interpreter needs to be updated to handle the new Float/Float4 opcodes and coercions

Comment 1

[Lars T Hansen]

I think the opcodes are supported as of some weeks ago.  It is specifically the two assertions that were added with the call analyzer this week that I was concerned about.

Comment 2

[Lars T Hansen]

Specifically WordcodeEmitter::writeCoerceToNumeric in WordcodeEmitter.cpp.

Comment 3

[Lars T Hansen]

I think there's more going on here.  The implementation of writeNip seems inappropriate for the wordcode interpreter, for one thing.  It looks like the wordcode interpreter has been forced into a JIT framework (down the path toward LIR_ffff2f4) and that is probably wrong.  I'm going to attach a patch that has some work in progres for a WOP_float4 opcode to fit into the current framework, but I suspect this is a dead end and that the fix is really at a higher level.

Comment 4

[Lars T Hansen]

Attachment: Work in progress, relative to tr-float 7081

Comment 5

[Lars T Hansen]

Attachment: Work in progress, refined

Resolves all test suite failures but one.  The whole emitCallpropertySlot() / writeNip() thing is evil and out of tune with how the interpreter works, but it looks like we can shoehorn things together OK.  There needs to be a better implementation of writeNip() for wordcode, too - the sequence of swap/pop emitted is seriously suboptimal for float4().

Comment 6

[Lars T Hansen]

changeset:   7086:4ea6fbb7ce77
tag:         tip
user:        Lars T Hansen <[e-mail]>
date:        Wed Dec 14 20:59:59 2011 +0100
summary:     Fix 708642 - Update Wordcode intepreter to handle float/float4