Closed Bug 708693 Opened 14 years ago Closed 14 years ago

Intermittent TEST-UNEXPECTED-FAIL | xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | test failed (with xpcshell return code: 0) | true == false

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Version:
11 Branch
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mak)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

ready to land
10.51 KB, patch
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=7822101&tree=Mozilla-Inbound Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test xpcshell on 2011-12-08 04:05:59 PST for push 8cccdec3532b TEST-INFO | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_changeBookmarkURI.js | running test ... TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_changeBookmarkURI.js | test passed (time: 367.909ms) TEST-INFO | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_getBookmarkedURIFor.js | running test ... TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_getBookmarkedURIFor.js | test passed (time: 410.502ms) TEST-INFO | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | running test ... TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | test failed (with xpcshell return code: 0), see following log: >>>>>>> TEST-INFO | (xpcshell/head.js) | test 1 pending Check that leyword does not exist TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [run_test : 92] null == null Add a bookmark with a keyword Check keyword for bookmark TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 51] null == null Check keyword for uri TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 55] null == null Check uri for keyword Check there are no orphan database entries TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 84] false == false Check keyword for bookmark TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 51] keyword == keyword Check keyword for uri TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 55] keyword == keyword Check uri for keyword TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 60] true == true TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 62] true == true Check there are no orphan database entries TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 84] false == false Check keyword for bookmark TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 51] keyword == keyword Check keyword for uri TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 55] keyword == keyword Check uri for keyword Skipping 79 lines... TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 55] keyword == keyword Check uri for keyword TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 60] true == true TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 62] true == true Check there are no orphan database entries TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 84] false == false Check keyword for bookmark TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 51] keyword == keyword Check keyword for uri TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 55] keyword == keyword Check uri for keyword TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 60] true == true TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 62] true == true Check there are no orphan database entries TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 84] false == false Remove a bookmark with a keyword, it should not be removed from others Check keyword for bookmark TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 51] keyword == keyword Check keyword for uri TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 55] keyword == keyword Check uri for keyword TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 60] true == true TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 62] true == true Check there are no orphan database entries TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | [check_keyword : 84] false == false Remove a folder containing bookmarks with keywords TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js | true == false - See following stack: JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 453 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: _do_check_eq :: line 547 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_eq :: line 568 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_false :: line 596 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js :: check_keyword :: line 71 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_keywords.js :: run_test :: line 138 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: _execute_test :: line 326 JS frame :: -e :: <TOP_LEVEL> :: line 1 TEST-INFO | (xpcshell/head.js) | exiting test <<<<<<< TEST-INFO | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_livemarks.js | running test ... TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_livemarks.js | test passed (time: 355.744ms)
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patch v1.0 (obsolete) — — Splinter Review
tests-only, I rewrote it to be a bit clearer. The issue is related to the fact orphan keywords are removed asynchronously now, the test was not waiting enough.
Attachment #580503 - Flags: review?(dietrich)
Attachment #580503 - Flags: review?(dietrich) → review+
Attached patch ready to land — — Splinter Review
the same patch, just with correct headers for someone to pick it up and land
Attachment #580503 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/fd241426865c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: