70874 - [HAVE FIX] Package stocks with oopsbot 2.x

Status: VERIFIED FIXED

(Webtools Graveyard :: Mozbot, defect)

Description

[Zach Lipton [:zach]]

Package stocks with oopsbot 2.x

yoda:/home/zach/botbot/BotModules/stocks.bm

Comment 1

[Hixie (not reading bugmail)]

will do. First, let's get the existing modules reviewed and accepted, then I'll
look at this one and review it. Do you have other modules I have to look at?
I recall you mentioned a reviewer module or something?

Comment 2

[Matthew Tuck [:CodeMachine]]

New QA.

Comment 3

[timeless]

If/when this is commited we need to revisit bug 41531 (divide by 0 in mozbot1.x stocks)

Comment 4

[Hixie (not reading bugmail)]

zach: Could you attach your patch to the bug? thanks

Comment 5

[Zach Lipton [:zach]]

Attachment: stocks.bm

Comment 6

[Hixie (not reading bugmail)]

looks good, I'll test it soon.

Comment 7

[Hixie (not reading bugmail)]

Attachment: Patch: Version 2

zach: please review. I am especially interested in knowing if you mind that I
changed the license to MPL only, to match the other Mozbot files.

Comment 8

[Zach Lipton [:zach]]

Comment on attachment 69043 [details] [diff] [review]
Patch: Version 2

r=zach

Comment 9

[Hixie (not reading bugmail)]

checked in

Comment 10

[Tanner M. Young [:tmyoung]]

Verified Fixed.