708876 - Password reset traceback

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Andy McKay]

File "/data/www/apps-preview.mozilla.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/apps-preview.mozilla.org/zamboni/vendor/src/django/django/views/decorators/cache.py", line 77, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)

  File "/data/www/apps-preview.mozilla.org/zamboni/apps/users/views.py", line 647, in password_reset_confirm
    form.save()

  File "/data/www/apps-preview.mozilla.org/zamboni/apps/users/forms.py", line 123, in save
    amo.log(amo.LOG.CHANGE_PASSWORD, user=self.user)

  File "/data/www/apps-preview.mozilla.org/zamboni/apps/amo/log.py", line 467, in log
    user = kw.get('user', get_user())

  File "/data/www/apps-preview.mozilla.org/zamboni/apps/amo/__init__.py", line 27, in get_user
    return _locals.user

AttributeError: 'thread._local' object has no attribute 'user'

Comment 1

[Andy McKay]

Ok I thought this was obvious, but its now. amo/log.py is being called without the kw argument user. Yet the traceback shows that it is. I would normally suspect pyc's for this but I know we remove them on push.

Comment 2

[Andy McKay]

but it's *not*

Comment 3

[Andy McKay]

Apps preview is dead. Password reset is gone. Re-open if it happens again.