708966 - dist/include/mozilla is filled late

Status: RESOLVED WORKSFORME

(Core :: MFBT, defect)

Description

[Mike Hommey [:glandium]]

Files under mfbt/ are currently installed in dist/include from js/src. This means that anything that is built before can't #include "mozilla/something.h".

Comment 1

[Benjamin Smedberg]

Later than what? js/src is built before almost everything else in the system, and we wanted to avoid spidermonkey having an outside dependency on mozilla code.

Comment 2

[Mike Hommey [:glandium]]

tier_base is the main thing that builds before js/src and it is going to grow. It would be nice to be able to use mfbt there.

Comment 3

[Benjamin Smedberg]

In what way is it going to grow requiring stuff in mfbt? I think we should avoid this if possible.

Comment 4

[Mike Hommey [:glandium]]

At the very least, being able to use StdInt.h would be good.

Comment 5

[Mike Hommey [:glandium]]

As a matter of fact, instead of implementing my own refcounting class, I'd rather use mfbt's.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Export MFBT headers early

This is enough for me to use mozilla/RefPtr.h in bug 683127, though I also need to add LOCAL_INCLUDES in my Makefiles so as to add js/src, which is kind of okay as long as I don't need extra symbols, which seems to be the case on non-debug builds. I expect debug builds to be broken by the requirement of JS_Assert.

Comment 7

[Mike Hommey [:glandium]]

This was actually solved separately in bug 711775