Add an empty components dir to b2g/

RESOLVED FIXED in mozilla11

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 580360 [details] [diff] [review]
Create the empty components directory

Fabrice need that for the camera application.
Attachment #580360 - Flags: review?
Attachment #580360 - Flags: review? → review?(jones.chris.g)
Attachment #580360 - Flags: review?(jones.chris.g) → review+
Blocks: 709468
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla11
Version: unspecified → Trunk
Attachment #580360 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/7c621c7bfea3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 2

6 years ago
I would like to suggest that a "components" subdirectory was a mistake when we added it to toolkit/ and browser/ which we've been slowly trying to rectify, and that it would be better to just use direct subdirectories, e.g. b2g/camera. Death to deep and mostly meaningless directory structures, please!
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> I would like to suggest that a "components" subdirectory was a mistake when
> we added it to toolkit/ and browser/ which we've been slowly trying to
> rectify, and that it would be better to just use direct subdirectories, e.g.
> b2g/camera. Death to deep and mostly meaningless directory structures,
> please!

Using direct subdirectories of the root folder sounds a bit overkill to me since the chrome, locales, theme, etc.. folders will be at the same level while they are semantically different.

What do you think of components/camera, components/comp1, component/comp3 instead?

Comment 4

6 years ago
Like components/ the name "chrome" is pretty much meaningless. We've used it poorly in the past to contain UI bits for lots of different functions. We should be organizing the code by function, not by the kind of file.

locales/ is segregated because that's how we manage source localization, not because that's a good structure for the code in general.

If we're going to have a bunch of builtin apps and you want to separate the apps from the core homescreen/UI code, then it might make sense to have b2g/apps/camera and b2g/apps/dialer and whatever else, but "components" could mean pretty much anything (in the past it has meant "stuff which is implemented as XPCOM components").
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)

> If we're going to have a bunch of builtin apps and you want to separate the
> apps from the core homescreen/UI code, then it might make sense to have
> b2g/apps/camera and b2g/apps/dialer and whatever else, but "components"
> could mean pretty much anything (in the past it has meant "stuff which is
> implemented as XPCOM components").

That's still what it meant to me. When I said "Fabrice need that for the camera application" that's because of some xpcom he needs for it.

Updated

6 years ago
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.