bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

[code quality] move es_search module code to SearchMixin for elastic

VERIFIED FIXED in 2012-01-24

Status

support.mozilla.org
Search
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: willkg, Assigned: willkg)

Tracking

unspecified
2012-01-24
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=dev c=search s=2012.1 p=2 post-sprint)

Zamboni uses an IndexMixin for models that are indexable.  When I wrote the indexing code for Elastic in Kitsune, I thought we wanted to keep it isolated so I put it in modules instead.

We should move the es_search module code to an IndexMixin and reduce the redundancy between the three es_search modules (forums, wiki, questions).
Putting "elastic" in the title so this bug is easier to find.
Summary: [code quality] move es_search module code to IndexMixin → [code quality] move es_search module code to IndexMixin for elastic
elasticutils extraced a SearchMixin. Documentation is at http://elasticutils.readthedocs.org/en/latest/django.html .

We should do something similar to that and additionally add methods:

    add_index_task
    add_unindex_task

which go through our task-squashing code.

Also of note, "fields" is equivalent to our "extract_document" code.
Grabbing this and tweaking the summary a bit.
Assignee: nobody → willkg
Summary: [code quality] move es_search module code to IndexMixin for elastic → [code quality] move es_search module code to SearchMixin for elastic
Tossing this in the 2012.1 sprint as a 2pter.
Whiteboard: u=user c=search s=2012.1 p=2 post-sprint
Blocks: 715926
Blocks: 715932
Blocks: 715896
(In reply to Will Kahn-Greene [:willkg] from comment #4)
> Tossing this in the 2012.1 sprint as a 2pter.

That requires a corresponding 2pt drop from the sprint, right?
Fixed in https://github.com/mozilla/kitsune/commit/4a0130c0c938fa11d796e599bcb89565c7321526

Things to check:

1. make sure the "reindex" button in the search admin still works (or works at all--not sure we've tested it, yet)

2. make sure creating questions, answers, threads, posts, and wiki pages all still work
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Sticking this in the 2011-01-24 milestone.
Target Milestone: --- → 2012-01-24
Whiteboard: u=user c=search s=2012.1 p=2 post-sprint → u=dev c=search s=2012.1 p=2 post-sprint
Verified creation of the above and also reindexing works
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.