709081 - [code quality] Use get_user() in Elastic tests rather than hard-coded IDs

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect, P3)

Description

[Erik Rose [:erik][:erikrose]]

Use users.tests.get_user() instead of hard-coding 118533. It just so happens that get_user() is specced to return that exact user.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is easy pickins.  Might as well do it now before we copy-and-paste all that code over and over again and make the code sillier.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this before we do more ES tests.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

ES tests use model makers now, so this is m00t.

Marking as WONTFIX since there's nothing to do here.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I missed the app-specific ES tests.  This is still a problem with questions/tests/test_es.py and forums/test/test_es.py.

Reopening.

Comment 5

[Erik Rose [:erik][:erikrose]]

Grabbing after talking to Will. I needed this to happen so I could kill the mixins and fixtures in the ES tests.

Comment 6

[Erik Rose [:erik][:erikrose]]

...which I need to happen so I can write decent tests for bug 710469.

Comment 7

[Erik Rose [:erik][:erikrose]]

Fixed in http://github.com/mozilla/kitsune/commit/cc9b4c826648c2dfec4f74972d4e7ea017c9d3a8.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pretty sure this lands in 2012-01-17.

Comment 9

[Rebecca Billings [:rbillings]]

Please add QA verification steps, or mark as [qa-], thanks

Comment 10

[Erik Rose [:erik][:erikrose]]

The tests verify this sufficiently. (Let see if the sprint graphs trip over this.)

Comment 11

[Rebecca Billings [:rbillings]]

Closed as [qa-]