709086 - Don't use JS_GetParent in mozJSSubScriptLoader::LoadSubScript

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

AFAICT, using JS_GetGlobalForObject is equivalent and less frowned upon.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 580413 [details] [diff] [review]
Patch v1

The right patch is just:

>-        JSObject *maybeGlob = JS_GetParent(cx, targetObj);
>-        while (maybeGlob) {
>-            targetObj = maybeGlob;
>-            maybeGlob = JS_GetParent(cx, maybeGlob);
>-        }
>+        targetObj = JS_GetGlobalForObject(cx, targetObj);

r=me with that change.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Indeed, thanks.

https://hg.mozilla.org/mozilla-central/rev/9c3ab8c81d28