709170 - Don't build Java debug when we don't have to

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Doug Turner (:dougt)]

http://mxr.mozilla.org/mozilla-central/source/config/android-common.mk#73

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: bug-709170-do-not-generate-local-var-symbols.patch

This change reduces .apk file size about 50 KB.

Omitting debug symbols for local variable names does not negatively affect our Java stack traces, which only include filenames and line numbers. BUT if anyone uses Eclipse for Java source-level debugging, they would be affected!

Also, the ProGuard optimizer will wipe out local variables (and symbols), so we don't lose much if javac omits these local variable symbols before ProGuard.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 590919 [details] [diff] [review]
bug-709170-do-not-generate-local-var-symbols.patch

Review of attachment 590919 [details] [diff] [review]:
-----------------------------------------------------------------

50K!

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: bug-709170-do-not-generate-local-var-symbols.patch

Rebased patch.

r=dougt

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60ce23560e51

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/60ce23560e51