Closed Bug 709170 Opened 8 years ago Closed 8 years ago

Don't build Java debug when we don't have to

Categories

(Firefox for Android :: General, defect, P4)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: dougt, Assigned: cpeterson)

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → cpeterson
Priority: -- → P4
This change reduces .apk file size about 50 KB.

Omitting debug symbols for local variable names does not negatively affect our Java stack traces, which only include filenames and line numbers. BUT if anyone uses Eclipse for Java source-level debugging, they would be affected!

Also, the ProGuard optimizer will wipe out local variables (and symbols), so we don't lose much if javac omits these local variable symbols before ProGuard.
Attachment #590919 - Flags: review?(doug.turner)
Comment on attachment 590919 [details] [diff] [review]
bug-709170-do-not-generate-local-var-symbols.patch

Review of attachment 590919 [details] [diff] [review]:
-----------------------------------------------------------------

50K!
Attachment #590919 - Flags: review?(doug.turner) → review+
Keywords: checkin-needed
Rebased patch.

r=dougt
Attachment #590919 - Attachment is obsolete: true
Attachment #592780 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/60ce23560e51
Status: NEW → ASSIGNED
Keywords: checkin-needed
OS: Mac OS X → Android
Hardware: x86 → All
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/60ce23560e51
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.