Closed
Bug 709321
Opened 13 years ago
Closed 12 years ago
Generate and upload keys
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P2)
Tracking
(firefox14 fixed, blocking-fennec1.0 +)
VERIFIED
FIXED
mozilla15
People
(Reporter: ally, Assigned: nalexander)
References
()
Details
(Whiteboard: [qa+])
Attachments
(1 file)
10.70 KB,
patch
|
mfinkle
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → rnewman
Comment 1•13 years ago
|
||
See Bug 709313 for a similar situation.
OS: Mac OS X → Android
Priority: P1 → P2
Hardware: x86 → All
Updated•12 years ago
|
tracking-fennec: --- → ?
Updated•12 years ago
|
tracking-fennec: ? → +
Assignee | ||
Comment 2•12 years ago
|
||
I can't guarantee it works, but we have code for it.
Reporter | ||
Updated•12 years ago
|
tracking-fennec: + → ---
blocking-fennec1.0: --- → +
Assignee | ||
Updated•12 years ago
|
Assignee: rnewman → nalexander
Assignee | ||
Comment 3•12 years ago
|
||
https://github.com/mozilla-services/android-sync/pull/166
Comment 4•12 years ago
|
||
What exactly is this bug for? Can we get a detailed description? Why do we need it? Really strange seeing a blocker with no content.
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Damon Sicore (:damons) from comment #4) > What exactly is this bug for? Can we get a detailed description? Why do we > need it? Really strange seeing a blocker with no content. At the moment, Android Sync does not correctly initialize a blank server. This ticket implements generating new keys and uploading the "crypto/keys" record to the server if it is not already present. We need this ticket to be a feature complete sync client that can operate without a companion client that prepares the server for us.
Comment 6•12 years ago
|
||
(In reply to Damon Sicore (:damons) from comment #4) > What exactly is this bug for? Can we get a detailed description? Why do we > need it? Really strange seeing a blocker with no content. Again, see Bug 745430 and Bug 745431 for descriptions of what this is for. Sync clients encounter blank servers on a routine basis.
Assignee | ||
Updated•12 years ago
|
Whiteboard: [patch waiting]
Reporter | ||
Updated•12 years ago
|
Whiteboard: [patch waiting] → [needs review rnewman]
Comment 7•12 years ago
|
||
Last iteration through the review cycle.
Status: NEW → ASSIGNED
Whiteboard: [needs review rnewman] → [waiting for final revised patch]
Assignee | ||
Updated•12 years ago
|
Whiteboard: [waiting for final revised patch] → [needs review :rnewman]
Comment 8•12 years ago
|
||
Reviewed and queued to land once it can be tested with other work as part of Bug 745430, Bug 745431. Testing snippets: 16:26:32 < rnewman> https://wiki.mozilla.org/Services/Sync/Snippets#Partially_corrupt_a_server 16:26:47 < rnewman> if you delete meta/global, you should see us freshStart (DELETE /storage) and start over 16:27:14 < rnewman> if you delete crypto/keys, we should generate new keys and blow away data, perhaps by freshStart 16:27:36 < rnewman> use this one: https://wiki.mozilla.org/Services/Sync/Snippets#Bump_meta.2Fglobal.27s_modified_time 16:27:45 < rnewman> to bump the modified time of crypto/keys without changing contents 16:27:48 < rnewman> we should handle that quietly 16:30:28 < rnewman> https://wiki.mozilla.org/Services/Sync/Snippets#Generate_new_keys
Whiteboard: [needs review :rnewman] → [waiting for merge][qa+]
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c42dd1bf025 Let's plan on uplifting this along with the rest of Bug 745430/Bug 745431.
Whiteboard: [waiting for merge][qa+] → [qa+]
Target Milestone: --- → mozilla15
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c42dd1bf025
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•12 years ago
|
||
Putting this here for lack of a better place. While testing crypto/keys upload in m-c: - sync device to existing account - bumped crypto/keys modified time using Components.utils.import("resource://services-sync/main.js"); Components.utils.import("resource://services-sync/resource.js"); let r = new Resource(Weave.Service.storageURL + "crypto/keys"); let g = r.get(); r.put(g); - sync completed just fine, and correctly fetched fresh keys quietly: I GlobalSession(13112) Running next stage ensureKeysStage (org.mozilla.gecko.sync.stage.EnsureCrypto5KeysStage@411f9870)... I EnsureC5KeysStage(13112) Fetching fresh collection keys for this session. D dalvikvm(13112) GC_CONCURRENT freed 556K, 10% free 8254K/9095K, paused 2ms+4ms I EnsureC5KeysStage(13112) New default key is the same as old default key; returning changed individual keys. - deleted crypto keys using Components.utils.import("resource://services-sync/main.js"); Components.utils.import("resource://services-sync/resource.js"); function deletePath(path) { let resource = new Resource(Weave.Service.storageURL + path); resource.setHeader("X-Confirm-Delete", "1"); return resource.delete(); } deletePath("crypto/keys"); - despite misleading logs, we did upload new keys correctly. I GlobalSession(13112) Running next stage ensureKeysStage (org.mozilla.gecko.sync.stage.EnsureCrypto5KeysStage@411152a8)... I EnsureC5KeysStage(13112) Fetching fresh collection keys for this session. W SSResourceDelegate(13112) HTTP request failed. W SSResourceDelegate(13112) HTTP response body: 404 Not Found W SSResourceDelegate(13112) W SSResourceDelegate(13112) The resource could not be found. I EnsureC5KeysStage(13112) Trying to use persisted collection keys for this session. I EnsureC5KeysStage(13112) Using persisted collection keys for this session. I SyncAdapter(13112) Stage completed: ensureKeysStage - subsequent sync recognizes that there are changed keys: I GlobalSession(13112) Running next stage ensureKeysStage (org.mozilla.gecko.sync.stage.EnsureCrypto5KeysStage@411664b0)... I EnsureC5KeysStage(13112) Fetching fresh collection keys for this session. D class ch.boye.httpclientandroidlib.impl.conn.tsccm.ThreadSafeClientConnManager(13112) Shutting down I EnsureC5KeysStage(13112) New default key is not the same as old default key. I EnsureC5KeysStage(13112) Fetched keys are not the same as persisted keys; setting fetched keys for this session before resetting changed engines. ... resetting stuff ... W GlobalSession(13112) Aborting sync: crypto/keys changed on server. - but we definitely have problems with clearing our persisted keys, and eventually we get HMAC errors. I GlobalSession(13112) Running next stage ensureKeysStage (org.mozilla.gecko.sync.stage.EnsureCrypto5KeysStage@41197f20)... I EnsureC5KeysStage(13112) Trying to use persisted collection keys for this session. I EnsureC5KeysStage(13112) Using persisted collection keys for this session. I SyncAdapter(13112) Stage completed: ensureKeysStage I GlobalSession(13112) Running next stage syncClientsEngine (org.mozilla.gecko.sync.stage.SyncClientsEngineStage@41165140)... D dalvikvm(13112) GC_CONCURRENT freed 501K, 10% free 8272K/9095K, paused 2ms+3ms W GlobalSession(13112) Aborting sync: Exception handling client WBO. W GlobalSession(13112) org.mozilla.gecko.sync.crypto.HMACVerificationException
Reporter | ||
Comment 12•12 years ago
|
||
Sync team: Definitely want to uplift to beta, but not during the first one. We are considering uplifting 709321/323 all together with other dependencies of 745430/431.
Whiteboard: [qa+] → [qa+][want uplift during betaN, but not right now]
Comment 13•12 years ago
|
||
[Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch:
Attachment #624876 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•12 years ago
|
Whiteboard: [qa+][want uplift during betaN, but not right now] → [qa+]
Reporter | ||
Comment 14•12 years ago
|
||
Comment on attachment 624876 [details] [diff] [review] Aurora uplift. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch: part of the meta/global implementation bundle of release blockers
Attachment #624876 -
Flags: approval-mozilla-beta?
Updated•12 years ago
|
status-firefox14:
--- → affected
Updated•12 years ago
|
Attachment #624876 -
Flags: approval-mozilla-beta?
Attachment #624876 -
Flags: approval-mozilla-aurora?
Attachment #624876 -
Flags: approval-mozilla-aurora+
Comment 16•12 years ago
|
||
I got a bunch of warnings on desktop when bumping crypto/keys modified time. But this appears to be ok.
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Product: Mozilla Services → Android Background Services
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•