709382 - require("simple-prefs").prefs should be iterable

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, enhancement, P2)

Description

[Erik Vold]

Jeff mentioned this in irc.

The following example should log all of the prefs being used:

 for ( name in prefSet.prefs ) { console.log(name); }

Comment 1

[Erik Vold]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/300

Pointer to Github pull-request

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 580708 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/300

The *simple-prefs* API additions look great, and the code looks good overall, but I would like to see the *preferences-service* API additions done a bit differently, as noted in the pull request.

Comment 3

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Any movement on this one?  I like Myk's comments/suggestion.  I want simple prefs to be an iterable of all prefs as well.  Less clear: should it keeps the 'startswith' aspect that the current prefs XPCOM has?

Comment 4

[Erik Vold]

Waiting for a review.

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Erik Vold from comment #4)
> Waiting for a review.

See review comments in pull request.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/6e2bb51c8d366f0d3fcf7e43f2d71236bf006124
Merge pull request #300 from erikvold/bug-709382

fix Bug 709382 require("simple-prefs").prefs should be iterable r=@gozala

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d75a094324e919126821f9eac61d2275c65cff72
Merge pull request #456 from Gozala/hotfix/prefs@709382

Bug 709382 - Fixing reference to wrong binding error introduced in #300 a=@gozala

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/fc0a50a27c361cafb6dd053a37e40c4493cb18ae
Merge pull request #457 from Gozala/hotfix/prefs@709382

Bug 709382 - Change test to don't rely on pref keys order a=@gozala