Closed Bug 709400 Opened 8 years ago Closed 8 years ago

Would like to to override nsIInlineSpellChecker with javascript but [noscript] methods are blocking it.

Categories

(Core :: Editor, defect)

7 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: josh, Assigned: khuey)

Details

(Whiteboard: [good first bug][mentor=ehsan])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110928 Firefox/7.0.1 SeaMonkey/2.4.1
Build ID: 20110928161145

Steps to reproduce:

I have a project that overrides nsIInlineSpellChecker in C++ code.
I would like to convert it to Javascript, but there are two [noscript] methods in nsIInlineSpellChecker that are blocking the creation of a Javascript object that can replace mozInlineSpellChecker successfully.

  [noscript] void init(in nsIEditor aEditor);
  [noscript] void cleanup(in boolean aDestroyingFrames);

Is [noscript] required on these methods?  Is it possible to remove it?
Looks like it was this way in the initial checkin http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/editor/txtsvc/public/nsIInlineSpellChecker.idl&rev=1.1&root=/cvsroot

I don't see any reason why we can't drop [noscript] here.  Ehsan?
Status: UNCONFIRMED → NEW
Component: General → Editor
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → editor
Yeah, we can do it.
Whiteboard: [good first bug][mentor=ehsan]
Attached patch Just do itSplinter Review
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #586053 - Flags: review?(ehsan)
Attachment #586053 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/65983b0e4a76
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.