709400 - Would like to to override nsIInlineSpellChecker with javascript but [noscript] methods are blocking it.

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[josh]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110928 Firefox/7.0.1 SeaMonkey/2.4.1
Build ID: 20110928161145

Steps to reproduce:

I have a project that overrides nsIInlineSpellChecker in C++ code.
I would like to convert it to Javascript, but there are two [noscript] methods in nsIInlineSpellChecker that are blocking the creation of a Javascript object that can replace mozInlineSpellChecker successfully.

  [noscript] void init(in nsIEditor aEditor);
  [noscript] void cleanup(in boolean aDestroyingFrames);

Is [noscript] required on these methods?  Is it possible to remove it?

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Looks like it was this way in the initial checkin http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/editor/txtsvc/public/nsIInlineSpellChecker.idl&rev=1.1&root=/cvsroot

I don't see any reason why we can't drop [noscript] here.  Ehsan?

Comment 2

[(no longer active)]

Yeah, we can do it.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Just do it

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/65983b0e4a76