709498 - if type is undefined for EventEmitter._removeAllListeners then all listeners should be removed

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, enhancement)

Description

[Erik Vold]

There appears to be some pieces of code that are not removing all listeners in destructors which can cause memory leaks.

So instead of having destructors loop through possible types and remove all listeners for those types, why not have the option of removing all listeners regardless of type?

Comment 1

[Erik Vold]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/298

Pointer to Github pull-request

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 580668 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/298

Great idea, and the patch looks great; r=@mykmelez!

Comment 3

[[github robot]]

Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f1ac348d95175ce41fd7b007ab768921f3acfd26
Merge pull request #298 from erikvold/bug-709498

fix Bug 709498 - EventEmitter._removeAllListeners no longer requires a type argument; r=@mykmelez