Closed Bug 709509 Opened 8 years ago Closed 8 years ago

Remove manual refcounting and QIing from nsBulletFrame::DidSetStyleContext

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #580671 - Flags: review?(dbaron)
Comment on attachment 580671 [details] [diff] [review]
Patch v1

It would make more sense to:
 * change mListener to nsRefPtr<nsBulletListener>
 * skip the |listener| variable entirely
Attachment #580671 - Flags: review?(dbaron) → review-
Attached patch Patch v2Splinter Review
Attachment #580671 - Attachment is obsolete: true
Attachment #582695 - Flags: review?(dbaron)
Comment on attachment 582695 [details] [diff] [review]
Patch v2

r=dbaron
Attachment #582695 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/2aa6d71c6839
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.