Remove manual refcounting and QIing from nsBulletFrame::DidSetStyleContext

RESOLVED FIXED in mozilla12

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 580671 [details] [diff] [review]
Patch v1
Attachment #580671 - Flags: review?(dbaron)
Comment on attachment 580671 [details] [diff] [review]
Patch v1

It would make more sense to:
 * change mListener to nsRefPtr<nsBulletListener>
 * skip the |listener| variable entirely
Attachment #580671 - Flags: review?(dbaron) → review-
(Assignee)

Comment 2

6 years ago
Created attachment 582695 [details] [diff] [review]
Patch v2
Attachment #580671 - Attachment is obsolete: true
Attachment #582695 - Flags: review?(dbaron)
Comment on attachment 582695 [details] [diff] [review]
Patch v2

r=dbaron
Attachment #582695 - Flags: review?(dbaron) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/2aa6d71c6839
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.