Last Comment Bug 709509 - Remove manual refcounting and QIing from nsBulletFrame::DidSetStyleContext
: Remove manual refcounting and QIing from nsBulletFrame::DidSetStyleContext
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-10 14:07 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-12-24 04:37 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.01 KB, patch)
2011-12-10 14:07 PST, :Ms2ger (⌚ UTC+1/+2)
dbaron: review-
Details | Diff | Splinter Review
Patch v2 (5.28 KB, patch)
2011-12-18 12:00 PST, :Ms2ger (⌚ UTC+1/+2)
dbaron: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-12-10 14:07:24 PST
Created attachment 580671 [details] [diff] [review]
Patch v1
Comment 1 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2011-12-12 12:22:40 PST
Comment on attachment 580671 [details] [diff] [review]
Patch v1

It would make more sense to:
 * change mListener to nsRefPtr<nsBulletListener>
 * skip the |listener| variable entirely
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-12-18 12:00:47 PST
Created attachment 582695 [details] [diff] [review]
Patch v2
Comment 3 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2011-12-20 09:14:15 PST
Comment on attachment 582695 [details] [diff] [review]
Patch v2

r=dbaron
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-12-24 04:37:26 PST
https://hg.mozilla.org/mozilla-central/rev/2aa6d71c6839

Note You need to log in before you can comment on or make changes to this bug.