70951 - nsIWebBrowserSetup needs a disable javascript method

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Judson Valeski]

This is so embeddors can disable javascript execution for a top level window.

Comment 1

[Mitchell Stoltz (not reading bugmail)]

Should the blocking of JS apply to sub-windows (such as iframes) within the
top-level window as well? If frames/iframes will always be blocked, then that's
irrelevant, but otherwise it's probably what we want.

Comment 2

[Judson Valeski]

yea, all subframes (if any) should have execution blocked as well.

Comment 3

[Mitchell Stoltz (not reading bugmail)]

Mass adding mozilla0.9 keyword (mass changing milestone doesn't seem to work).

Comment 4

[Marek Z. Jeziorek]

Mitch, this bug has no taget milestone. Could you make sure that it gets done in 
either 0.8.1 or 0.9? Thanks.

Comment 5

[Mitchell Stoltz (not reading bugmail)]

Attachment: First crack at a patch (also covers bug 55069)

Comment 6

[Mitchell Stoltz (not reading bugmail)]

Jud et al,
   Does embedding (or any other project that you know of) need the ability to
disable some forms of active content but not others? Or will it always be
all-or-nothing? We could combine the proposed no-js, no-plugins, etc., flags
into a single no-active-content flag and save some interface clutter.

Comment 7

[Judson Valeski]

I'm not aware of a strict granular need. The more broad enable/disable you
describe is probably the way to go, the trouble is defining the "etc" you mentioned.

Active content = JS, plugins (including java) for sure, but what about CSS,
animated gifs, meta refresh? Those latter 3 I can see someone wanting to isolate
individually; no?

Comment 8

[timeless]

for non embedding the following should be treated indivdually:
JS, individual plugin providers (including java), css, genuine http, meta 
(separate form genuine?), animated gifs.

do we have the ability to disable/ignore <frameset>,<frame> and <iframe>?

Comment 9

[Judson Valeski]

ok, sounds like we should keep it all separate then.

iframe content is 69455

Comment 10

[Mitchell Stoltz (not reading bugmail)]

Attachment: Better patch - ready for review. Also covers bug 55069.

Comment 11

[Marc Attinasi]

GetRootDocShell needs a little cleanup - discussed on IRC. sr=attinasi pending
that cleanup.

Comment 12

[Scott MacGregor]

sr=mscott (pending the comments Marc asked you to change).

Mitch, are you going to check in teh patch I sent you to go with 55069 as well
or  should I do that?

Comment 13

[Mitchell Stoltz (not reading bugmail)]

Attachment: patch with tab cleanup and attinasi's suggestions

Comment 14

[Mitchell Stoltz (not reading bugmail)]

Scott, I'll check it all in. Thanx.

Comment 15

[Mitchell Stoltz (not reading bugmail)]

Checked in. Let me know if this is what you guys need.