709536 - columnset reflow sometimes doesn't remove NS_FRAME_IN_REFLOW

Status: RESOLVED INCOMPLETE

(Core :: Layout, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

###!!! ABORT: must call nsHTMLReflowState& version during reflow: '!(f->GetStateBits() & NS_FRAME_IN_REFLOW)', file layout/base/nsLayoutUtils.cpp, line 4772

This is the same abort as in bug 708036, but the testcase and stack seem different.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Aaron Train [:aaronmt]]

Related bug 709651?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think errors during reflow are causing the nsColumnSetFrame to not have its NS_FRAME_IN_REFLOW bit cleared at the end of reflow.

Comment 4

[Bob Clary [:bc] (inactive)]

Automation reproduced this with the same stack at http://fishki.net/comment.php?id=106840 on 32bit and 64 bit Linux Beta/11, Aurora/12, Nightly/13 but I can't reproduce it locally.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This assertion is removed in bug 707195 patch 3.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

... but comment 3 is still a real problem even so.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No longer at all related to readability since the assertion is gone, but still a real bug (and something we should perhaps have assertions to catch).

Comment 8

[Mats Palmgren (inactive)]

Bug 81268 is somewhat related.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This no longer reproduces.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d4e57ea2b3f

Comment 12

[Mats Palmgren (inactive)]

See comment 5 - 7

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Sorry about that, at least we have a testcase landed now if/when anyone ever gets back to it :)

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d4e57ea2b3f

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mats, maybe it's time to close this bug?

Comment 16

[Mats Palmgren (inactive)]

No.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mats, maybe it's time to close this bug?

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mats, maybe it's time to close this bug?

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mats, maybe it's time to close this bug?

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:dholbert, maybe it's time to close this bug?

Comment 21

[Daniel Holbert [:dholbert]]

Nope. We should drop the leave-open keyword here, though. (It only serves a purpose for a short period after a landing to prevent the auto-closing.)

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has severity 'critical'.
:dholbert, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 24

[Daniel Holbert [:dholbert]]

Sounds like this was left open for comment 3 (a somewhat theoretical issue from 11 years ago).

To the extent that that was an issue at that point, it's not clear whether it persists at this point. Let's close this as INCOMPLETE for now. We can reopen or file new bugs if we discover something actionable.

(The testcase here has also already been landed as a crashtest, in comment 11.)