Closed Bug 709562 Opened 10 years ago Closed 10 years ago

nsAutoDialWin does not need to load rasapi32/rasdlg dynamically

Categories

(Core :: Networking, defect)

All
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(2 files)

Current Gecko doesn't run on Windows 9x and NT4.0.  So it is unnecessary to use LoadLibrary for rasapi32.dll and rasdlg.dll.
Summary: nsAutoDialWin is unnecessary to load rasapi32/rasdlg dynamically → nsAutoDialWin does not need to load rasapi32/rasdlg dynamically
Attached patch fixSplinter Review
Assignee: nobody → m_kato
Attachment #580822 - Flags: review?(jmathies)
Comment on attachment 580822 [details] [diff] [review]
fix

Presumably this is to help bug 709193? This looks fine.
Attachment #580822 - Flags: review?(jmathies) → review+
Blocks: deadcode
Did the patch land?
Attachment #583091 - Flags: review?(taras.mozilla)
Attachment #583091 - Flags: review?(taras.mozilla) → review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/6ed882263c14
https://hg.mozilla.org/mozilla-central/rev/6c8e6f6a8ac8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.