OS/2 0228, TP 770x, WSeB, SDD, fresh install. When running Mozilla for the first time, the "Migrate Profile" dialog box comes up to allow you to migrate your existing NS/2 4.x profiles forward. There are two problems: 1) There is no default location for the keyboard input (either one of the two on-screen buttons), so the user can't use the keyboard to select options without knowing they have to press the TAB key first. 2) Even if you manage to get the highlight on the pushbutton the ENTER key doesn't activate the function (which all normal CUA application should react to). I don't have my Win32 system nearby me to verify if this is a cross-platform problem. I'll attach a picture showing the lack of a default highlight.
Created attachment 26816 [details] Note the lack of a default action keyboard highlight in this dialog. It is possible to set via TAB.
Confirmed Platform: PC OS: Linux 2.2.17 Mozilla Build: 2001030108 Marking NEW.
Okay, I've found a meta bug for this. Meta bug <a href="http://bugzilla.mozilla.org/show_bug.cgi?id=18575"> 18575 </a> covers these things, so I'll add this one on to it and re-assign to Alec Flett to figure out who to send this to.
Going to attach a patch that does the following: 1) Make the "Migrate" button focused by default 2) Make "enter" select the "Migrate" button (standard enter-selects-default mapping) 3) Make "escape" select the "Manage" button All along, space will select whichever button is currently focused (that works already).
Created attachment 26983 [details] [diff] [review] Patch to make this dialog do more normal dialog-ish things
looks good to me r=ksosez (not that it means anything but i feel good :)
Alec, could you sr?
I agree with the pre-highlighting the Migrate button and the ESC key mapping, but should Enter really force selection of the Migrate option? That's more of a mnemonic accelerator key setting, isn't it? If I read what you're saying correctly, this would mean that even if I had the cursor highlight over the Manage option and pressed Enter I would be bumped back to Migrate? In OS/2 and Windows, the Enter key selects the option that is highlighted by the cursor highlight, so this goes a bit against the grain for them. The Windows and OS/2 System Control Panels has several multiple pushbutton options that demonstrate this effect. I realise that this is a bit meta for this bug, so I'll see what bugs I can find that describe Mozilla keyboarding default mappings...
sr=alecf on the second patch.
Barry, basically I just gave that dialog the standard "dialog" keybindings, with Migrate being like the OK button and Manage being like the Cancel button. Those keybindings are specified by OS-specific dialog overlays, and what I described above are the current keybindings in the OS/2 overlay. So you should be seeing the behavior I described in all Mozilla dialogs that have an OK and cancel button -- preferences, popups asking whether to save passwords/form data, and so on. If those keybindings are inconsstent with what OS/2 usually does, I would suggest filing a more general bug on that. I could certainly hack this one dialog to act differently, but it's better to fix it for everything at once.
OK, after talking to some people about how the dialog buttons are supposed to behave, bug 71196 has been filed on generic dialog button behavior.
thanks for the patch
fix checked in
I'm willing to take someone else's Verify on this. OS/2 builds are not a daily event... plus I'm on dial-up for the next couple of days (which makes pulling any build painful).
Barry, Would you verify on your OS/2 system please?