Closed Bug 709595 Opened 8 years ago Closed 8 years ago

name threads and timers

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

patch v.1
4.41 KB, patch
blassey
: review+
Details | Diff | Splinter Review 
traceview shows threads.  be nice and set a name for every thread and timer.
Attached patch patch v.1 — — Splinter Review
Assignee: nobody → doug.turner
Attachment #580756 - Flags: review?(blassey.bugs)
Comment on attachment 580756 [details] [diff] [review]
patch v.1

Review of attachment 580756 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +145,5 @@
>          public SynchronousQueue<Handler> mHandlerQueue =
>              new SynchronousQueue<Handler>();
>          
>          public void run() {
> +            setName("GeckoLooper Thread");

maybe call this one the "Main UI thread"
Attachment #580756 - Flags: review?(blassey.bugs) → review+
Comment on attachment 580756 [details] [diff] [review]
patch v.1

Review of attachment 580756 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +145,5 @@
>          public SynchronousQueue<Handler> mHandlerQueue =
>              new SynchronousQueue<Handler>();
>          
>          public void run() {
> +            setName("GeckoLooper Thread");

got this one wrong, please name it "Background Thread"
https://hg.mozilla.org/mozilla-central/rev/05d5c4ef7efc
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.