709734 - Add-on Builder stopped saving/opening some files

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Antonio Merker]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0.1) Gecko/20100101 Firefox/8.0.1
Build ID: 20111120135848

Steps to reproduce:

Using Add-on Kit 1.2.1 on Firefox 8.0.1 (Windows 7 64bit, Kubuntu Linux 64 bit) with a private add-on.

1. Open Add-on Builder and open any JS file from "Data" directory (= content script)
2. Make some changes
3. Save (works fine, revision number is updated)
4. Make some more changes
5. Save for the second time --> [ISSUE 1]

The following issues seem to be merely symptoms of larger problems...

6. Go to main.js (via tab)
7. Try to go back to JS (via tab) --> [ISSUE 2]

8. Close the JS file
9. Try to re-open it (via left-side navigation) --> [ISSUE 3]


Actual results:

[ISSUE 1]
The revision popup comes up, but the revision number stays the same. Nothing is saved on the server (verified by window refresh).

Also, this error appears in the Firefox console:
Error: a is undefined
Source File: https://builder.addons.mozilla.org/media/jetpack/js/ide-min.js?4edfde5a
Line: 1

[ISSUE 2]
The tab is not switched back to the JS. Instead, the same error as in ISSUE 1 appears in the console.

[ISSUE 3]
The file is not re-opened. Instead, this error appears in the console:

Error: this.current is undefined
Source File: https://builder.addons.mozilla.org/media/jetpack/js/ide-min.js?4edfde5a
Line: 1


Expected results:

[ISSUE 1] All changes should have been saved, no console error should have appeared, and the revision number should have been updated.

[ISSUE 2] The active tab should have been switched to the clicked JS file.

[ISSUE 3] The JS file should have opened.

Interestingly, this problem does not pertain to files from the "Lib" directory, only the content scripts from the "Data" directory or subdirectories. I've tried to clear the cache, logging out and back in, restarting Firefox, deleting the problematic files and re-uploading them, all to no avail. The Builder has worked flawlessly for the last ~700 revisions. Problems started to arise around the 1.3 release (which is not present in the dropdown menu for the "Addon Kit"), so I've had this problem for about a week now.

Possibly, this bug is related to #709724. A more detailed description: https://forums.mozilla.org/addons/viewtopic.php?f=27&t=4415

Comment 1

[Sean McArthur [:seanmonstar]]

Thanks for reporting this. And terribly sorry for the screw up.

Comment 2

[Sean McArthur [:seanmonstar]]

This has been fixed in master: https://github.com/mozilla/FlightDeck/commit/1d7fc351383532e26b9d98e0ef4757dea6f59f0b

It will get pushed live later today.

Comment 3

[Antonio Merker]

Awesome, thanks for the quick fix!

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This seems to have regressed with a recent push.

I wasn't able to reproduce his [ISSUE 1], but I could reproduce [ISSUE 2] and [ISSUE 3].

Comment 5

[Piotr Zalewa [:zalun]]

Confirmed - Issue 2 and 3 are still happening

Comment 6

[Sean McArthur [:seanmonstar]]

fixed again

https://github.com/mozilla/FlightDeck/commit/5e6b4a709da5426a6937bd258cdd8f967c8c65e8