Having taken part in the test study on the development channel, the study is now complete, but I haven't been prompted to submit my data.
The error console says:
Error: popup is null
Source File: resource://testpilot/modules/notifications.js
Looks like as we removed the feedback button, we've not got a notification option. Is there somewhere else we could hang this from?
Mconley, do you mind taking a look at this? It should be fairly straightforward.
I can take it.
Created attachment 581822 [details] [diff] [review]
This should fix up test pilot for us.
- Notifications (they now get displayed, anchored to the toolbar)
- Build test pilot on all channels (i.e. include release)
- Looks the same on all channels
- Links in the experiment page now open in the browser, and use the FF style one.
- Removes obsolete interface.js.orig
- Removes the preferences box that was meant for mobile and not the browser.
Comment on attachment 581822 [details] [diff] [review]
Review of attachment 581822 [details] [diff] [review]:
So, I'm not so happy with the flash you can see in http://dl.dropbox.com/u/2301433/Screenshots/TestPilotFlash.png and the notification pops up in a bit of a weird place as seen in http://grab.by/bpeC , but I'm going to say ui-r=me for now, and we can fix these later.
And I'm pretty happy with the code, too, so r=me, modulo the comments below.
@@ -6,4 +6,4 @@
> > xmlns:em="http://www.mozilla.org/2004/em-rdf#">
> > <Description about="urn:mozilla:install-manifest">
> > <em:id>email@example.com</em:id>
> > - <em:version>1.3.1</em:version>
> > + <em:version>1.3.2</em:version>
The version you sent me on IRC said "1.3.1" and "By: Mozilla Messaging". As long as those are "1.3.2" and "Mozilla Corporation" (or "Mozilla"), I'm happy with that.
@@ -186,4 +189,4 @@
> > // Show the popup:
> > popup.hidden = false;
> > popup.setAttribute("open", "true");
> > - popup.openPopup( anchor, "after_end");
> > + // XXX Thunderbird needs after_start for now.
Why is this? If it's a reasonable reason, can we remove the "XXX"? If not, can we file a followup bug?
I had to do a follow-up to create the panel in the menu bar element rather than the toolbar, as this was messing up the migration assistant. The position is still the same though. This also fixed the unit tests on trunk:
> -<toolbar id="mail-bar3">
> +<toolbar id="mail-toolbox">
shouldn't this be <*toolbox* id="mail-toolbox">
Hm - yes, it should be.
Checked in an additional fix for the element tag, with r=mconley over irc:
Checked in additional additional fix to comm-central as:
and to aurora as:
this also made it onto comm-release (comm-beta isn't required at this time, as that had already merged to release):