709845 - Copy-paste of link from URL bar after opening link from Facebook Android app gives redirect link, not the target

Status: VERIFIED FIXED

Description

[Brion Vibber]

User Agent: Mozilla/5.0 (Ubuntu; X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111115183813

Steps to reproduce:

Followed a few links from Facebook (using Android Facebook app) opening them directly in Firefox nightly (20111212).

After loading, tap into the URL bar, tap-and hold for 'select all', then 'copy'.



Actual results:

A long ugly http://m.facebook.com/blah blah redirect URL is shown and copied.


Expected results:

The destination URL should have been copied.

Note that I can't reproduce this simply opening an HTTP redirect page such as http://leuksman.com/misc/redirect1.php within Fennec itself. It may be specific to opening from another app, or from the way the facebook redirectors work.

Comment 1

[Chris Peterson [:cpeterson]]

Created attachment 588273 [details] [diff] [review]
bug-709845-part-1-update-history-url.patch

Update the tab history's URL after a redirect.

Comment 2

[Chris Peterson [:cpeterson]]

Created attachment 588274 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings.patch

Tab.java: Fix some checkstyle warnings about extra imports, missing access modifiers, trailing whitespace.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 588274 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings.patch

next time just factor code cleanup in its own bug.

Comment 4

[Chris Peterson [:cpeterson]]

Created attachment 589246 [details] [diff] [review]
bug-709845-part-1-update-history-url-v1-rebased.patch

Rebased patch.

r=mbrubeck

Comment 5

[Chris Peterson [:cpeterson]]

Created attachment 589248 [details] [diff] [review]
bug-709845-part-1-update-history-url-v1-rebased.patch

r=mbrubeck

Comment 6

[Chris Peterson [:cpeterson]]

Created attachment 589250 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings-v1-rebased.patch

Rebased patch. r=dougt

Comment 7

[Chris Peterson [:cpeterson]]

checkin-needed for rebased patches.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d27ddb7ad032
https://hg.mozilla.org/integration/mozilla-inbound/rev/339d1d51af7a

Comment 9

[:Ms2ger (⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d27ddb7ad032
https://hg.mozilla.org/mozilla-central/rev/339d1d51af7a

Comment 10

[Chris Peterson [:cpeterson]]

Comment on attachment 589248 [details] [diff] [review]
bug-709845-part-1-update-history-url-v1-rebased.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: Bookmarked and copy/pasted URLs will grab the REDIRECTING page's URL, not the REDIRECTED TO page's URL.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Tab history might mix up pages' URLs.

Comment 11

[Chris Peterson [:cpeterson]]

Comment on attachment 589250 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings-v1-rebased.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: None because this patch correct code style warnings.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Probably none.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ab94103a2cdd

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/07e692bcb977

Comment 14

[Andreea Pod]

Verified fixed on:
-build:  Firefox for Android 21.0a2 (2013-02-27), Firefox for Android 22.0a1 (2013-02-27)
-device: Samsung Galaxy Tab 10.1
-OS: Android 3.1