Closed Bug 709845 Opened 9 years ago Closed 9 years ago

Copy-paste of link from URL bar after opening link from Facebook Android app gives redirect link, not the target

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---

People

(Reporter: brion, Assigned: cpeterson)

Details

(Whiteboard: [MTD])

Attachments

(2 files, 3 obsolete files)

User Agent: Mozilla/5.0 (Ubuntu; X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111115183813

Steps to reproduce:

Followed a few links from Facebook (using Android Facebook app) opening them directly in Firefox nightly (20111212).

After loading, tap into the URL bar, tap-and hold for 'select all', then 'copy'.



Actual results:

A long ugly http://m.facebook.com/blah blah redirect URL is shown and copied.


Expected results:

The destination URL should have been copied.

Note that I can't reproduce this simply opening an HTTP redirect page such as http://leuksman.com/misc/redirect1.php within Fennec itself. It may be specific to opening from another app, or from the way the facebook redirectors work.
Whiteboard: [MTD]
Assignee: nobody → cpeterson
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Status: NEW → ASSIGNED
OS: Linux → Android
Hardware: x86_64 → ARM
tracking-fennec: --- → 11+
Update the tab history's URL after a redirect.
Attachment #588273 - Flags: review?(doug.turner)
Tab.java: Fix some checkstyle warnings about extra imports, missing access modifiers, trailing whitespace.
Attachment #588274 - Flags: review?(doug.turner)
Attachment #588273 - Flags: review?(doug.turner) → review?(mbrubeck)
Comment on attachment 588274 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings.patch

next time just factor code cleanup in its own bug.
Attachment #588274 - Flags: review?(doug.turner) → review+
Attachment #588273 - Flags: review?(mbrubeck) → review+
Keywords: checkin-needed
Rebased patch.

r=mbrubeck
Attachment #589246 - Flags: review+
r=mbrubeck
Attachment #588273 - Attachment is obsolete: true
Attachment #589246 - Attachment is obsolete: true
Attachment #589248 - Flags: review+
Rebased patch. r=dougt
Attachment #588274 - Attachment is obsolete: true
Attachment #589250 - Flags: review+
checkin-needed for rebased patches.
https://hg.mozilla.org/mozilla-central/rev/d27ddb7ad032
https://hg.mozilla.org/mozilla-central/rev/339d1d51af7a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 589248 [details] [diff] [review]
bug-709845-part-1-update-history-url-v1-rebased.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: Bookmarked and copy/pasted URLs will grab the REDIRECTING page's URL, not the REDIRECTED TO page's URL.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Tab history might mix up pages' URLs.
Attachment #589248 - Flags: approval-mozilla-aurora?
Comment on attachment 589250 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings-v1-rebased.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: None because this patch correct code style warnings.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Probably none.
Attachment #589250 - Flags: approval-mozilla-aurora?
Attachment #589248 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #589250 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
-build:  Firefox for Android 21.0a2 (2013-02-27), Firefox for Android 22.0a1 (2013-02-27)
-device: Samsung Galaxy Tab 10.1
-OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.