Copy-paste of link from URL bar after opening link from Facebook Android app gives redirect link, not the target

VERIFIED FIXED in Firefox 11

Status

()

Product:
Firefox for Android
Component:
General
Type:
defect
Importance:
P2
normal
Status:
VERIFIED FIXED
Opened:
8 years ago
Updated:
6 years ago

People

(Reporter: brion, Assigned: cpeterson)

Tracking

Version:
unspecified
Target:
Firefox 12
Platform:
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

(Whiteboard: [MTD])

Attachments

(2 attachments, 3 obsolete attachments)

bug-709845-part-1-update-history-url-v1-rebased.patch
2.52 KB, patch
cpeterson
: review+
blassey
: approval-mozilla-aurora+
Details | Diff | Splinter Review
bug-709845-part-2-fix-checkstyle-warnings-v1-rebased.patch
5.72 KB, patch
cpeterson
: review+
blassey
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Reporter

Description

•
8 years ago 
User Agent: Mozilla/5.0 (Ubuntu; X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111115183813

Steps to reproduce:

Followed a few links from Facebook (using Android Facebook app) opening them directly in Firefox nightly (20111212).

After loading, tap into the URL bar, tap-and hold for 'select all', then 'copy'.



Actual results:

A long ugly http://m.facebook.com/blah blah redirect URL is shown and copied.


Expected results:

The destination URL should have been copied.

Note that I can't reproduce this simply opening an HTTP redirect page such as http://leuksman.com/misc/redirect1.php within Fennec itself. It may be specific to opening from another app, or from the way the facebook redirectors work.
 Reporter

Updated

•
8 years ago
Whiteboard: [MTD]
Assignee: nobody → cpeterson
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
 Assignee

Updated

•
8 years ago
Status: NEW → ASSIGNED
OS: Linux → Android
Hardware: x86_64 → ARM
tracking-fennec: --- → 11+
 Assignee

Comment 1

•
8 years ago 
Update the tab history's URL after a redirect.
Attachment #588273 - Flags: review?(doug.turner)
 Assignee

Comment 2

•
8 years ago 
Tab.java: Fix some checkstyle warnings about extra imports, missing access modifiers, trailing whitespace.
Attachment #588274 - Flags: review?(doug.turner)
Attachment #588273 - Flags: review?(doug.turner) → review?(mbrubeck)

Comment 3

•
8 years ago 
Comment on attachment 588274 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings.patch

next time just factor code cleanup in its own bug.
Attachment #588274 - Flags: review?(doug.turner) → review+
Attachment #588273 - Flags: review?(mbrubeck) → review+
 Assignee

Updated

•
8 years ago
Keywords: checkin-needed
 Assignee

Comment 4

•
8 years ago 
Rebased patch.

r=mbrubeck
Attachment #589246 - Flags: review+
 Assignee

Comment 5

•
8 years ago 
r=mbrubeck
Attachment #588273 - Attachment is obsolete: true
Attachment #589246 - Attachment is obsolete: true
Attachment #589248 - Flags: review+
 Assignee

Comment 6

•
8 years ago 
Rebased patch. r=dougt
Attachment #588274 - Attachment is obsolete: true
Attachment #589250 - Flags: review+
 Assignee

Comment 7

•
8 years ago 
checkin-needed for rebased patches.

Comment 9

•
8 years ago 
https://hg.mozilla.org/mozilla-central/rev/d27ddb7ad032
https://hg.mozilla.org/mozilla-central/rev/339d1d51af7a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
 Assignee

Comment 10

•
8 years ago 
Comment on attachment 589248 [details] [diff] [review]
bug-709845-part-1-update-history-url-v1-rebased.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: Bookmarked and copy/pasted URLs will grab the REDIRECTING page's URL, not the REDIRECTED TO page's URL.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Tab history might mix up pages' URLs.
Attachment #589248 - Flags: approval-mozilla-aurora?
 Assignee

Comment 11

•
8 years ago 
Comment on attachment 589250 [details] [diff] [review]
bug-709845-part-2-fix-checkstyle-warnings-v1-rebased.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: None because this patch correct code style warnings.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Probably none.
Attachment #589250 - Flags: approval-mozilla-aurora?
Attachment #589248 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #589250 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 14

•
6 years ago 
Verified fixed on:
-build:  Firefox for Android 21.0a2 (2013-02-27), Firefox for Android 22.0a1 (2013-02-27)
-device: Samsung Galaxy Tab 10.1
-OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.