Last Comment Bug 709947 - Don't use the ESSL backend of ANGLE
: Don't use the ESSL backend of ANGLE
: verified-beta
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla11
Assigned To: Benoit Jacob [:bjacob] (mostly away)
: Milan Sreckovic [:milan]
Depends on:
Blocks: 684863 709712
  Show dependency treegraph
Reported: 2011-12-12 13:43 PST by Benoit Jacob [:bjacob] (mostly away)
Modified: 2011-12-21 02:28 PST (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

don't use ESSL backend (1.35 KB, patch)
2011-12-12 13:43 PST, Benoit Jacob [:bjacob] (mostly away)
jgilbert: review+
Details | Diff | Splinter Review
don't use ESSL backend, for landing on mozilla-beta (2.00 KB, patch)
2011-12-12 15:39 PST, Benoit Jacob [:bjacob] (mostly away)
jacob.benoit.1: review+
christian: approval‑mozilla‑aurora+
akeybl: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description Benoit Jacob [:bjacob] (mostly away) 2011-12-12 13:43:24 PST
Created attachment 581036 [details] [diff] [review]
don't use ESSL backend

We don't need a ESSL backend in ANGLE, since we don't currently perform shader transformations on platforms that use OpenGL ES.

So we used to just happily use the GLSL backend everywhere, and actually that used to be all what there was, but a few months ago I saw that new ESSL backend and I though: oh, shiny! And I proudly wrote that line of code:

           gl->IsGLES2() ? SH_ESSL_OUTPUT : SH_GLSL_OUTPUT,

Now it turns out that we've had terrible WebGL crashiness on Android lately (see e.g. bug 684863 and bug 709712) and revertion to just


fixes all of these crashes.

Again, it doesn't matter that we're getting GLSL output, on ES we just discard it and use the original source (stripped from comments) to feed glShaderSource. So no functional behavior change will happen as a result from this change. This is true as long as we don't use any shader transformation on ES. (We currently only do on Mac, which uses desktop GL).
Comment 1 Benoit Jacob [:bjacob] (mostly away) 2011-12-12 15:39:12 PST
Created attachment 581075 [details] [diff] [review]
don't use ESSL backend, for landing on mozilla-beta
Comment 2 Alex Keybl [:akeybl] 2011-12-12 15:41:28 PST
Comment on attachment 581075 [details] [diff] [review]
don't use ESSL backend, for landing on mozilla-beta

[Triage Comment]
Approving for beta given the WebGL strategic landscape on mobile, and the fact that this is now even lower risk (Android specific).
Comment 3 Benoit Jacob [:bjacob] (mostly away) 2011-12-12 15:49:11 PST

keeping open for central and aurora
Comment 4 Catalin Suciu [:csuciu] 2011-12-14 06:34:17 PST
I verified this on Firefox9 Beta6 and didn't see any crashes.
Mozilla /5.0 (Android;Linux armv7l;rv:9.0) Gecko/20111212 Firefox/9.0 Fennec/9.0 
Device: HTC Desire (Android 2.2)
Comment 5 Benoit Jacob [:bjacob] (mostly away) 2011-12-14 11:57:06 PST
Comment on attachment 581075 [details] [diff] [review]
don't use ESSL backend, for landing on mozilla-beta

OK, there only remains to land this on Aurora. Please!
Comment 6 Joe Drew (not getting mail) 2011-12-14 12:00:02 PST
I accidentally left myself as the committer of record when landing this in mozilla-central. I understand that this will go on my permanent record.
Comment 7 christian 2011-12-14 14:38:23 PST
We need this on aurora as well.
Comment 8 Benoit Jacob [:bjacob] (mostly away) 2011-12-14 15:04:33 PST
That's why there is a approval? flag on this patch. Please grant!
Comment 9 christian 2011-12-14 15:09:20 PST
Comment on attachment 581075 [details] [diff] [review]
don't use ESSL backend, for landing on mozilla-beta

Whoops, must have missed it.
Comment 10 Benoit Jacob [:bjacob] (mostly away) 2011-12-16 14:12:06 PST

Note You need to log in before you can comment on or make changes to this bug.