709951 - After changing file name/extension all subsequent saves to that file fail silently

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Daniel Buchner [:dbuc]]

Steps to reproduce:

Copy this add-on: https://builder-addons-dev.allizom.org/addon/1019387/latest/

1. Test the add-on, you'll see a panel with "foo" in it
2. Change the "foo" in foo.html to "foo1", retest, you'll see "foo1" in the panel
3. Change the name of the file to bar.html, and change the contentURL of the panel instantiation in main.js to match. Retest, and you should still see "foo1".
4. Now change "foo1" in the bar.html file to "bar"m, you will never see your changes applied, it will still show a panel with "foo1".

Something about the file name mod is breaking all subsequent saves. I am guessing a similar file UID issue is to blame. The editor and the save loop fixes itself if you uninstall the test add-on and then reload the page.

Please advise.

Comment 1

[Sean McArthur [:seanmonstar]]

fixed this in master.

https://github.com/seanmonstar/FlightDeck/commit/a5a1b47e83378e41ac11d9de9c16a3ed7cf8342a