709995 - Installing the same app multiple times installs it multiple times in the Dashboard causing serious issues to the Dashboard

Status: VERIFIED FIXED

(Web Apps :: Extension, defect, P1)

Description

[Mohamed Dabbagh]

Attachment: Screenshot

When the user installs an app multiple times, it will get installed multiple times in the Dashboard. If you then uninstall one of the duplicate apps, the Dashboard will become unusable. If you keep the Dashboard open and go to another tab and install a new app, it will be placed over the duplicate app. If you close and re-launch the Dashboard, a new app icon is displayed (see attachments) with no name. This new 'app' is now unusable. The user cannot delete it, cannot launch it and cannot interact with it in an expected manner. 

Steps to Reproduce:
1. Launch Firefox
2. Install the Apps extension - Tried with openwebapps-adb507752d-12_12_2011.xpi from http://people.mozilla.com/~dclarke/openwebapps/Extension/
3. Go to https://apps-preview-dev.allizom.org/en-US/apps/, log-in and install an app
4. Install the same app again
5. Go to myapps.mozillalabs.com - Notice apps shows multiple times
6. Delete one of the duplicate apps

Actual Results:
The Dashboard is now not usable and the user must close and relaunch the Dashboard. 

Expected Results:
Installing the same app multiple times should not install it multiple times in the Dashboard.

Comment 1

[Mohamed Dabbagh]

So it seems that you have to have the Dashboard already launched in another tab and install the app multiple times in order to see it multiple times in the Dashboard. If you install the app multiple times and then launch the Dashboard, the app will only be installed once.

Comment 2

[Ian Bicking (:ianbicking)]

That sounds like an error with how the dashboard is using watchUpdates

Comment 3

[Bill Walker [:bwalker] [@wfwalker]]

Dan believes this can be fixed on the server side.

Comment 4

[Ian Bicking (:ianbicking)]

Yes, this bug is in a file that is deployed to myapps, not something embedded in the addon.

Comment 5

[Dan Walkowski]

fixed:
https://github.com/mozilla/openwebapps/commit/7600beb05891c249dbccd96fe334bbaddf3043dd

Comment 7

[Ian Bicking (:ianbicking)]

Deployed on myapps

Comment 8

[Dan Walkowski]

r+ anant

Comment 9

[Mohamed Dabbagh]

Tested on Firefox 9b5 with openwebapps-325550d8ca-12_13_2011.xpi from http://people.mozilla.com/~dclarke/openwebapps/Extension/ and without having the extension installed as well (HTML5 shim). Tried the scenario mentioned in the bug and tried other scenarios (without first launching the Dashboard and trying to install different apps multiple times) and only one app is installed now. I verified that the apps can be interacted with in the Dashboard as well after attempting multiple installs (launching, uninstalling and re-positioning).