Groups pages don't have pagination

VERIFIED FIXED

Status

Participation Infrastructure
Phonebook
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Unfocused, Assigned: Davidw93)

Tracking

Details

Groups pages show only the first 20 results - presumably for pagination, but there's no pagination links.

For example, the most epic of epic groups has (as of today) 38 members, but only shows 20 members:
https://mozillians.org/en-US/group/191-beards
I confirm the issue... 

I'm a member of the Beards group, and have the option to leave the group, but I'm not present among the 20 face-furry Mozillians listed...

Comment 2

6 years ago
Reps group confirmed too, I'm not in the 20 chosen ones :)

Comment 3

6 years ago
There is still no pagination, but our LDAP removal means all the users show up.
Summary: Groups pages don't have pagination, only show first 20 results → Groups pages don't have pagination
(Assignee)

Updated

6 years ago
Assignee: nobody → davidw93.dw
(Assignee)

Comment 4

6 years ago
Pull Request: https://github.com/mozilla/mozillians/pull/144

Comments: Added pagination to groups page along with infinite scrolling.
I tested manually with 23 accounts in 1 group and it seemed to work. If someone could test properly(or show me the ways of the tests) it would be great!

I'm still kinda new to this stuff so i don't fully know how this pull request will go down :)
(Assignee)

Comment 5

6 years ago
Final pull request : https://github.com/mozilla/mozillians/pull/148

Fixed bugs in infinite scroll js file.
Tidied up method for pagination in groups.

Much happier with this one.

Comment 6

6 years ago
Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/d22c3fe4166c643ddb52fe194dcfff7e9df61605
Merge pull request #148 from davidw93/bug710075

Bug 710075 - Infinite Scroll on groups

Also fixes a bug in infinite.js (impacts search view)
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Component: mozillians.org → Phonebook
Product: Websites → Community Tools
QA Contact: mozillians-org → phonebook
Version: unspecified → other
Bumping to QA verified - this has landed on production. Great bug .. thanks for filing and Davidw93 thanks for the wicked good fix.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.