Closed Bug 710096 Opened 8 years ago Closed 8 years ago

Keep the tile origin and viewport metrics in sync

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

Attachments

(1 file)

Currently, the tile origin and viewport metrics can get out of sync because there's no locking involved. This results in random checkerboards when you pan and zoom around, as well as flashes when you navigate from page to page.
Attached patch Proposed patch.Splinter Review
Proposed patch attached. This eliminates little fragments of checkerboards as you pan around by simply requiring callers to take the layer controller's monitor before changing the viewport metrics or rendering.
Attachment #581163 - Flags: review?(chrislord.net)
Comment on attachment 581163 [details] [diff] [review]
Proposed patch.

Review of attachment 581163 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #581163 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/mozilla-central/rev/58a278555680
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified fixed on: 
Nightly 13.0a1(2012-03-04)
Device: Samsung Galaxy S2
OS: Android 2.3.4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.