71011 - Themes for single packages don't work

Status: RESOLVED INVALID

(SeaMonkey :: Themes, defect)

Description

[Pete Collins (MDG)]

Themes for single packages don't work.

For example, if you create a skin for navigator only, it will install through
the UI, reside in the users mozilla chrome dir is registered for use in
all-skins.rdf but doesn't work.

It apperas in the `Apply Theme' menu. However it throws this exception:

JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80520006 [nsIChromeRegistry.refreshSkins]"  nsresult: "0x80520006
(<unknown>)"  location: "JS frame :: chrome://navigator/content/navigator.js ::
applyTheme :: line 2180"  data: no]


Now, if i take the same exact theme and carry all of the other packages skin
directories from say modern, add them in to the contents.rdf file for this jar,
it will then work.

This a problem.  In chameleon for example, i have to bundle:
 
aim  communicator  editor  global  messenger  

In addition to my target skin for navigator in order for the skin to work.

Maybe, i'm just missing something.

--pete

Comment 1

[Pete Collins (MDG)]

Attachment: test case jar for navigator package only

Comment 2

[[e-mail]]

I couldn't get its name to appear in the Apply Theme menu but clicking on the
empty space at the bottom of the menu threw the following JS exception:
JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code: 0x8
0004003 (NS_ERROR_INVALID_POINTER) [nsIChromeRegistry.selectSkin]"  nsresult: "0
x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://navigator
/content/navigator.js :: applyTheme :: line 1301"  data: no]

Comment 3

[David Hyatt]

Accepting.

Comment 4

[David Hyatt]

This bug is invalid.  The chrome registry scans the contents.rdf file and only 
appends package names and provider types as needed.  In the case of a 
contents.rdf file that contains only ONE provider type ("skin") and ONE package 
("navigator"), no subdirectories are required.

Eliminate the navigator subdirectory within the JAR, and the package will 
register just fine.