Test that simple-pref listeners are removed on unload

RESOLVED FIXED

Status

Add-on SDK
General
P1
trivial
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Erik Vold, Assigned: Erik Vold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This bug was resolved by https://github.com/mozilla/addon-sdk/commit/f1ac348d95175ce41fd7b007ab768921f3acfd26 but we should get this test in there anyway.
(Assignee)

Updated

6 years ago
Assignee: nobody → erikvvold
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Priority: -- → P1
(Assignee)

Comment 1

6 years ago
Created attachment 582169 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/306

Pointer to Github pull-request
(Assignee)

Updated

6 years ago
Attachment #582169 - Flags: review?(myk)
Comment on attachment 582169 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/306

Looks good, just a couple minor issues.
Attachment #582169 - Flags: review?(myk) → review-
(Assignee)

Updated

6 years ago
Depends on: 738111
(Assignee)

Updated

6 years ago
Attachment #582169 - Flags: review?(rFobic)

Comment 3

6 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ee036f5d2bc3d74235a16cd81491279c01eeedfb
Merge pull request #306 from erikvold/bug-710117

fix bug 710117 testing that pref listeners are removed on unload r=@gozala

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Attachment #582169 - Flags: review?(rFobic) → review+
You need to log in before you can comment on or make changes to this bug.